From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17706: 24.4.50; locked file error in rmail-insert-inbox-text Date: Sat, 14 Jun 2014 16:16:31 +0300 Message-ID: <831turws0g.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1402751844 10854 80.91.229.3 (14 Jun 2014 13:17:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Jun 2014 13:17:24 +0000 (UTC) Cc: 17706@debbugs.gnu.org To: Ken Olum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 14 15:17:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wvnpc-0000Ch-OR for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jun 2014 15:17:16 +0200 Original-Received: from localhost ([::1]:35417 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wvnpc-0006jB-B3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jun 2014 09:17:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvnpT-0006iA-T9 for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 09:17:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvnpO-0007tj-I1 for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 09:17:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvnpO-0007tf-Ea for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 09:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WvnpO-0006bn-0u for bug-gnu-emacs@gnu.org; Sat, 14 Jun 2014 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jun 2014 13:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17706-submit@debbugs.gnu.org id=B17706.140275181025374 (code B ref 17706); Sat, 14 Jun 2014 13:17:01 +0000 Original-Received: (at 17706) by debbugs.gnu.org; 14 Jun 2014 13:16:50 +0000 Original-Received: from localhost ([127.0.0.1]:47278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WvnpB-0006bA-OW for submit@debbugs.gnu.org; Sat, 14 Jun 2014 09:16:50 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:50435) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvnp8-0006aq-Ha for 17706@debbugs.gnu.org; Sat, 14 Jun 2014 09:16:47 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0N7500200TJYM700@mtaout24.012.net.il> for 17706@debbugs.gnu.org; Sat, 14 Jun 2014 16:12:42 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N7500N34U16QV60@mtaout24.012.net.il>; Sat, 14 Jun 2014 16:12:42 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90379 Archived-At: > From: Ken Olum > Cc: 17706@debbugs.gnu.org > Date: Sat, 14 Jun 2014 08:16:39 -0400 > > So maybe it would be better to actually lock the file. Then we'd be > using file locks as intended. The way I'd do it is to lock the file in > rmail-get-new-mail-1 before calling rmail-insert-inbox-text and then > unlock it after saving the file with the new messages or after > discovering that there are none. > > Unfortunately, there doesn't seem to be any lisp interface to lock_file, > but I guess I could set buffer-modified-p and then call lock-buffer. > > What do you think? Sounds OK to me.