From: Eli Zaretskii <eliz@gnu.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 18051@debbugs.gnu.org
Subject: bug#18051: 24.3.92; ls-lisp: Sorting; make ls-lisp-string-lessp a normal function?
Date: Fri, 18 Jul 2014 12:46:26 +0300 [thread overview]
Message-ID: <831ttj6lu5.fsf@gnu.org> (raw)
In-Reply-To: <874myfatyo.fsf@web.de>
> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: 18051@debbugs.gnu.org
> Date: Fri, 18 Jul 2014 11:37:19 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > > could I please get my `ls-lisp-string-lessp' defined as a function?
> >
> > You can always redefine the functions that call it, no?
>
> That would cover the whole switch processing algorithm,
> `ls-lisp-handle-switches', 60 lines of code. I would shadow any future
> change in that code by redefining that huge function. That's why I
> wanted to avoid that.
You are going to override the behavior of the package anyway, so I
don't see the big difference.
> What's the advantage of `ls-lisp-string-lessp' being a defsubst?
From my POV, making sure the package always behaves as designed, I
guess. You agreed with my motivation, so it sounds like a
contradiction to me to still push for the change.
Anyway, if others think the comparison of file names should be up for
grabs, I won't fight the change just because I think it's wrong.
next prev parent reply other threads:[~2014-07-18 9:46 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XMiOq-0000si-VD@vcs.savannah.gnu.org>
2014-07-18 6:22 ` bug#18051: 24.3.92; ls-lisp: Sorting; make ls-lisp-string-lessp a normal function? Michael Heerdegen
2014-07-18 6:53 ` Eli Zaretskii
2014-07-18 7:33 ` Michael Heerdegen
2014-07-18 8:53 ` Eli Zaretskii
2014-07-18 9:37 ` Michael Heerdegen
2014-07-18 9:46 ` Eli Zaretskii [this message]
2014-07-18 10:18 ` Michael Heerdegen
2014-07-18 13:03 ` Eli Zaretskii
2014-07-19 1:25 ` Michael Heerdegen
2014-07-19 8:17 ` Eli Zaretskii
2014-07-19 10:52 ` Michael Heerdegen
2014-07-19 10:56 ` Eli Zaretskii
2014-07-18 9:24 ` Michael Albinus
2014-07-18 9:33 ` Eli Zaretskii
2014-07-18 10:12 ` Michael Albinus
2014-07-18 12:57 ` Eli Zaretskii
2014-07-18 13:18 ` Michael Albinus
2014-07-18 13:44 ` Eli Zaretskii
2014-07-18 16:21 ` Michael Albinus
2014-07-20 5:49 ` Michael Heerdegen
2014-07-20 6:07 ` Eli Zaretskii
2014-07-20 6:21 ` Michael Heerdegen
2014-07-20 6:33 ` Eli Zaretskii
2014-07-20 7:30 ` Michael Heerdegen
2014-07-20 8:14 ` Eli Zaretskii
2014-07-20 8:24 ` Michael Heerdegen
2014-07-20 8:38 ` Eli Zaretskii
2014-07-20 9:15 ` Michael Heerdegen
2014-07-20 9:18 ` Eli Zaretskii
2014-07-20 11:44 ` Michael Albinus
2014-07-20 11:59 ` Eli Zaretskii
2014-07-20 15:26 ` Michael Albinus
2014-07-20 16:16 ` Eli Zaretskii
2014-08-16 21:52 ` Michael Albinus
2014-08-17 16:38 ` Eli Zaretskii
2014-08-17 17:55 ` Eli Zaretskii
2014-08-17 18:46 ` Michael Albinus
2014-08-17 18:52 ` Eli Zaretskii
2014-08-21 9:05 ` Michael Albinus
2014-08-21 14:41 ` Eli Zaretskii
2014-08-22 14:23 ` Michael Albinus
2014-08-23 9:05 ` Eli Zaretskii
2014-08-23 16:42 ` Michael Albinus
2014-08-23 17:33 ` Eli Zaretskii
2014-08-23 20:32 ` Michael Albinus
2014-08-24 14:54 ` Eli Zaretskii
2014-08-24 16:18 ` Michael Albinus
2014-08-25 15:01 ` Stefan Monnier
2014-08-27 8:49 ` Michael Albinus
2014-08-27 15:37 ` Eli Zaretskii
2014-08-27 18:02 ` Michael Albinus
2014-08-27 15:48 ` Glenn Morris
2014-08-27 16:53 ` Eli Zaretskii
2014-08-28 3:23 ` Stefan Monnier
2014-08-27 18:08 ` Michael Albinus
2014-08-27 18:30 ` Glenn Morris
2014-08-25 16:45 ` Glenn Morris
2014-08-25 17:36 ` Eli Zaretskii
2014-07-20 6:18 ` Michael Heerdegen
2014-07-20 14:22 ` Stefan Monnier
2014-08-27 23:57 ` bug#18051: trunk r117751: Improve robustness of new string-collation code Katsumi Yamaoka
2014-08-28 0:51 ` Paul Eggert
2014-08-28 3:09 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831ttj6lu5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18051@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.