From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18136: 24.4.50; crash in redisplay when calling load-theme Date: Wed, 30 Jul 2014 20:52:47 +0300 Message-ID: <831tt2u428.fsf@gnu.org> References: <87d2cpxaq1.fsf@holos.localdomain> <8338dkh6wo.fsf@gnu.org> <53D77B06.8040907@gmx.at> <83tx60fjnh.fsf@gnu.org> <53D7A965.30700@gmx.at> <83mwbste5o.fsf@gnu.org> <53D7C0C4.7070406@gmx.at> <83iomgt9d2.fsf@gnu.org> <53D7E6B6.6070007@gmx.at> <83fvhkt3wm.fsf@gnu.org> <53D9210E.2030800@gmx.at> <8361ieu5nr.fsf@gnu.org> <53D92D00.7070600@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1406742805 26934 80.91.229.3 (30 Jul 2014 17:53:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Jul 2014 17:53:25 +0000 (UTC) Cc: mvoteiza@udel.edu, 18136@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 30 19:53:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XCY3x-0002UM-BG for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Jul 2014 19:53:17 +0200 Original-Received: from localhost ([::1]:52503 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCY3u-0007SP-R0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Jul 2014 13:53:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCY3n-0007SI-En for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2014 13:53:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XCY3i-0004vb-OX for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2014 13:53:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XCY3i-0004vX-Kr for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2014 13:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XCY3i-0008KJ-19 for bug-gnu-emacs@gnu.org; Wed, 30 Jul 2014 13:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jul 2014 17:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18136 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18136-submit@debbugs.gnu.org id=B18136.140674275731973 (code B ref 18136); Wed, 30 Jul 2014 17:53:01 +0000 Original-Received: (at 18136) by debbugs.gnu.org; 30 Jul 2014 17:52:37 +0000 Original-Received: from localhost ([127.0.0.1]:52076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XCY3I-0008Jc-76 for submit@debbugs.gnu.org; Wed, 30 Jul 2014 13:52:36 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:60945) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XCY3F-0008JL-Fs for 18136@debbugs.gnu.org; Wed, 30 Jul 2014 13:52:34 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N9J00400DMJAM00@a-mtaout22.012.net.il> for 18136@debbugs.gnu.org; Wed, 30 Jul 2014 20:52:27 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9J004E8DNE7I10@a-mtaout22.012.net.il>; Wed, 30 Jul 2014 20:52:27 +0300 (IDT) In-reply-to: <53D92D00.7070600@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91982 Archived-At: > Date: Wed, 30 Jul 2014 19:36:00 +0200 > From: martin rudalics > CC: mvoteiza@udel.edu, 18136@debbugs.gnu.org > > >> > No, we resize the frame and then redistribute the frame dimensions > >> > between its windows. When change_frame_size_1 is called with the same > >> > dimensions as the current frame's dimensions, it simply does nothing > >> > and returns. > >> > >> change_frame_size_1 _always_ calls adjust_frame_size now. And the later > >> does (almost) nothing only if the following condition holds: > >> > >> if (new_text_width == old_text_width > >> && new_text_height == old_text_height > >> && new_windows_width == old_windows_width > >> && new_windows_height == old_windows_height > >> && new_pixel_width == old_pixel_width > >> && new_pixel_height == old_pixel_height) > >> /* No change. Sanitize window sizes and return. */ > > > > OK, but that's the moral equivalent of what I described (based on what > > the code did previously). Right? > > I'm not good in morals but if I remove the menubar and the "frame > dimensions" remain the same, the above conjunct does not hold because the > new text height is larger than the old one and the new windows height too. I thought we agreed that TTY frames should include the menu bar in their height, and therefore change_frame_size should not have its 3rd argument decreased by FRAME_MENU_BAR_LINES for TTY frames.