From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19865: tar-untar-buffer: should honor default-directory Date: Sat, 14 Feb 2015 21:28:51 +0200 Message-ID: <831tlswavg.fsf@gnu.org> References: <87a90gd91b.fsf@violet.siamics.net> <87fva8bi4v.fsf@violet.siamics.net> <83h9uowhxh.fsf@gnu.org> <877fvkbdpw.fsf@violet.siamics.net> <83a90gwfpl.fsf@gnu.org> <873868bbvk.fsf@violet.siamics.net> <8361b4wd8d.fsf@gnu.org> <87y4o09ukb.fsf@violet.siamics.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1423942166 16666 80.91.229.3 (14 Feb 2015 19:29:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Feb 2015 19:29:26 +0000 (UTC) Cc: 19865@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 14 20:29:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YMiOw-0005CR-9H for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Feb 2015 20:29:14 +0100 Original-Received: from localhost ([::1]:60934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMiOv-0003O2-GA for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Feb 2015 14:29:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMiOn-0003N4-Fv for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 14:29:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMiOk-00073D-9K for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 14:29:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMiOk-000738-5u for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 14:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YMiOj-0007MJ-PM for bug-gnu-emacs@gnu.org; Sat, 14 Feb 2015 14:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Feb 2015 19:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19865 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19865-submit@debbugs.gnu.org id=B19865.142394214028275 (code B ref 19865); Sat, 14 Feb 2015 19:29:01 +0000 Original-Received: (at 19865) by debbugs.gnu.org; 14 Feb 2015 19:29:00 +0000 Original-Received: from localhost ([127.0.0.1]:44177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMiOh-0007Lz-NW for submit@debbugs.gnu.org; Sat, 14 Feb 2015 14:29:00 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:64913) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YMiOe-0007Lk-R6 for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 14:28:58 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NJS000000JZT200@a-mtaout22.012.net.il> for 19865@debbugs.gnu.org; Sat, 14 Feb 2015 21:28:50 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJS000F20S1IJA0@a-mtaout22.012.net.il>; Sat, 14 Feb 2015 21:28:50 +0200 (IST) In-reply-to: <87y4o09ukb.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99411 Archived-At: > From: Ivan Shmakov > Date: Sat, 14 Feb 2015 19:12:04 +0000 > > >> And I’d still like to hear why you think that tar-untar-buffer > >> /must/ use the value of default-directory local to a buffer /other/ > >> than the one the user called this command from. > > > Because it's simpler, and makes the code easier to follow. > > My former patch expands the code by a single line; my latter one > adds two more for a comment (while removing one level of nesting > from a fair chunk of the code at the same time.) How is that > making it any harder to follow? Length of code is only one factor, insignificant in this case. Subtle dependencies between different parts of the code, as well as overriding the default-directory value, is what complicates things in this case. > Besides, as I’ve already noted, it does make tar-untar-buffer > more consistent with both the rest of tar-mode.el, /and/ the > rest of Emacs. I thus believe that a single extra LoC is fully > justified here. Once again, we disagree, there's no doubt about that. There's no need to reiterate things you already wrote, as they have been duly noted.