From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Add FIXME comment re stack overflow and modules Date: Mon, 21 Dec 2015 20:10:19 +0200 Message-ID: <831tafsmes.fsf@gnu.org> References: <83h9jbssx2.fsf@gnu.org> <5678398A.7020409@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1450721401 24740 80.91.229.3 (21 Dec 2015 18:10:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Dec 2015 18:10:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 21 19:09:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aB4uB-0008NN-MG for ged-emacs-devel@m.gmane.org; Mon, 21 Dec 2015 19:09:55 +0100 Original-Received: from localhost ([::1]:46708 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB4uB-0007dv-2d for ged-emacs-devel@m.gmane.org; Mon, 21 Dec 2015 13:09:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB4u8-0007dh-0r for emacs-devel@gnu.org; Mon, 21 Dec 2015 13:09:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aB4u4-0006RV-RG for emacs-devel@gnu.org; Mon, 21 Dec 2015 13:09:51 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB4u4-0006RR-O9; Mon, 21 Dec 2015 13:09:48 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1279 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aB4u3-0002Tr-UX; Mon, 21 Dec 2015 13:09:48 -0500 In-reply-to: <5678398A.7020409@cs.ucla.edu> (message from Paul Eggert on Mon, 21 Dec 2015 09:40:26 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196619 Archived-At: > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Mon, 21 Dec 2015 09:40:26 -0800 > > Eli Zaretskii wrote: > > By "does not work" here, did you mean that using MODULE_FUNCTION_BEGIN > > will fail to catch the jump out of the SIGSEGV handler? > > I did not analyze emacs-module.h and emacs-module.c carefully enough to find the > exact problem areas. IMO, it hardly makes sense to have comments that add confusion rather than explain clearly the issues. I clarified that comment a bit. > For example, the module code contains comments like "It is very > important that pushing the handler doesn't itself raise a signal" > that suggest that the corresponding code is incompatible with stack > overflow checking. I think it refers to Fsignal, not to signals caught by sigaction handlers.