From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Add FIXME comment re stack overflow and modules
Date: Mon, 21 Dec 2015 20:10:19 +0200 [thread overview]
Message-ID: <831tafsmes.fsf@gnu.org> (raw)
In-Reply-To: <5678398A.7020409@cs.ucla.edu> (message from Paul Eggert on Mon, 21 Dec 2015 09:40:26 -0800)
> Cc: emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Mon, 21 Dec 2015 09:40:26 -0800
>
> Eli Zaretskii wrote:
> > By "does not work" here, did you mean that using MODULE_FUNCTION_BEGIN
> > will fail to catch the jump out of the SIGSEGV handler?
>
> I did not analyze emacs-module.h and emacs-module.c carefully enough to find the
> exact problem areas.
IMO, it hardly makes sense to have comments that add confusion rather
than explain clearly the issues. I clarified that comment a bit.
> For example, the module code contains comments like "It is very
> important that pushing the handler doesn't itself raise a signal"
> that suggest that the corresponding code is incompatible with stack
> overflow checking.
I think it refers to Fsignal, not to signals caught by sigaction
handlers.
next prev parent reply other threads:[~2015-12-21 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 15:49 Add FIXME comment re stack overflow and modules Eli Zaretskii
2015-12-21 17:40 ` Paul Eggert
2015-12-21 18:10 ` Eli Zaretskii [this message]
2015-12-21 18:29 ` Paul Eggert
2015-12-21 19:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831tafsmes.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.