From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22453: [PATCH] Support for switching to hexl-mode from image mode Date: Sun, 24 Jan 2016 18:07:08 +0200 Message-ID: <831t973qs3.fsf@gnu.org> References: <1453617036-17528-1-git-send-email-kuleshovmail@gmail.com> <83fuxn3ufa.fsf@gnu.org> <20160124145941.GA1301@localhost> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1453651648 31699 80.91.229.3 (24 Jan 2016 16:07:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Jan 2016 16:07:28 +0000 (UTC) Cc: 22453@debbugs.gnu.org To: Alexander Kuleshov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 24 17:07:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aNNC8-0004ns-F3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Jan 2016 17:07:16 +0100 Original-Received: from localhost ([::1]:60917 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNNC7-0000Cy-Kv for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Jan 2016 11:07:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNNC0-00009o-Tk for bug-gnu-emacs@gnu.org; Sun, 24 Jan 2016 11:07:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNNBw-0004KK-Iq for bug-gnu-emacs@gnu.org; Sun, 24 Jan 2016 11:07:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNNBw-0004Ij-F4 for bug-gnu-emacs@gnu.org; Sun, 24 Jan 2016 11:07:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aNNBt-00082h-Ub for bug-gnu-emacs@gnu.org; Sun, 24 Jan 2016 11:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jan 2016 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22453-submit@debbugs.gnu.org id=B22453.145365161830905 (code B ref 22453); Sun, 24 Jan 2016 16:07:01 +0000 Original-Received: (at 22453) by debbugs.gnu.org; 24 Jan 2016 16:06:58 +0000 Original-Received: from localhost ([127.0.0.1]:35049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNNBq-00082P-0i for submit@debbugs.gnu.org; Sun, 24 Jan 2016 11:06:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43183) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aNNBo-00082D-Ab for 22453@debbugs.gnu.org; Sun, 24 Jan 2016 11:06:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNNBe-0004HK-2m for 22453@debbugs.gnu.org; Sun, 24 Jan 2016 11:06:51 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNNBd-0004HG-W7; Sun, 24 Jan 2016 11:06:46 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3992 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aNNBd-0004jF-5w; Sun, 24 Jan 2016 11:06:45 -0500 In-reply-to: <20160124145941.GA1301@localhost> (message from Alexander Kuleshov on Sun, 24 Jan 2016 20:59:41 +0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111920 Archived-At: > Date: Sun, 24 Jan 2016 20:59:41 +0600 > From: Alexander Kuleshov > Cc: Alexander Kuleshov , 22453@debbugs.gnu.org > > > . Please provide a ChangeLog-style commit log message for the > > changes (some details are in CONTRIBUTE). > > Ok, will do, just one question. where do I need add it? As you may > see I added some description to the commit message. Do I need to > do something additional? But anyway, I will look into CONTRIBUTE. It is best to make a local commit to your private branch, write the commit log message using "C-x 4 a", and then produce the patch using "git format-patch". > > > +(defun image-toggle-hex-display () > > > + "Toggle between image and text display. > > > +If the current buffer is displaying an image file as an image, > > > +call `image-mode-as-hex' to switch to text. Otherwise, display > > > +the image by calling `image-mode'." > > > > It is best to avoid referring to another command in a doc string, if > > you can avoid that. In this case, the reference doesn't add any > > useful information, so I think it should be deleted. > > Are you about `image-mode-as-hex`? I've copied it from the image-toggle-display > doc string. Do we need to delete it there too? Yes, please delete the reference in both doc strings. > > Last, but not least, I think this contribution is too large to accept > > without legal paperwork. I don't see your copyright assignment on > > file; would you like me to send you the form so you could start the > > paperwork rolling? > > Yes, sure. Sent off-list. Thanks.