From: Eli Zaretskii <eliz@gnu.org>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
Subject: Re: Tests, Emacs-25 and Conditional Features
Date: Fri, 18 Mar 2016 13:07:18 +0200 [thread overview]
Message-ID: <831t789h95.fsf@gnu.org> (raw)
In-Reply-To: <87zitwf4pz.fsf@russet.org.uk> (phillip.lord@russet.org.uk)
> From: phillip.lord@russet.org.uk (Phillip Lord)
> Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
> Date: Fri, 18 Mar 2016 10:41:28 +0000
>
> > More generally, I don't see how Emacs could know what you believe. We
> > need to define the meaning of that first, and then find a way to
> > communicate that to Emacs.
>
> Something like
>
> (skip-unless (or (gnutls-available-p) conditional-feature-force))
>
> So, we pick have a standard test selector which means "all the
> conditional features should be expected to be on". Probably, you would
> want "all the conditional features that are supposed to be on by
> default, should be expected to be on"
That won't be useful at all: many such features are
platform-dependent, for example. It makes very little sense to try
invoking w32notify or w32-shell-execute on GNU/Linux. Likewise with
features that depend on specific GUI toolkits.
> > Then there's the issue of how do you test this. An API that was not
> > compiled into Emacs cannot be invoked, so what do we want to show the
> > user? a "void function" error? ert error messages are not so easy to
> > interpret.
>
> It would be nice if there were a standard way of detecting this. As
> Michael's example shows, we have a gnutls-available-p function which
> is defined if gnutls is not available, but for libxml, we check for
> non-definition of functions.
It would be trivial to add a libxml2-available-p function, but I fail
to see how is this different from using fboundp. And AFAIU, in the
context of this discussion, you don't want to trust the likes of
gnutls-available-p, either.
next prev parent reply other threads:[~2016-03-18 11:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 13:36 Tests, Emacs-25 and Conditional Features Phillip Lord
2016-03-16 14:29 ` Michael Albinus
2016-03-17 10:14 ` Phillip Lord
2016-03-17 16:25 ` Eli Zaretskii
2016-03-18 10:41 ` Phillip Lord
2016-03-18 11:00 ` Michael Albinus
2016-03-18 17:19 ` Phillip Lord
2016-03-18 18:38 ` Eli Zaretskii
2016-03-18 11:07 ` Eli Zaretskii [this message]
2016-03-18 17:20 ` Phillip Lord
2016-03-18 18:37 ` Eli Zaretskii
2016-03-19 21:26 ` Phillip Lord
2016-03-18 15:15 ` Stefan Monnier
2016-03-18 15:41 ` Eli Zaretskii
2016-03-18 15:54 ` Stefan Monnier
2016-03-18 18:32 ` Eli Zaretskii
2016-03-18 17:22 ` Phillip Lord
2016-03-16 15:48 ` Dmitry Gutov
2016-03-16 16:12 ` Eli Zaretskii
2016-03-16 18:53 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831t789h95.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.