From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23186: closed (Re: bug#23186: 25.0.92; Tramp: Windows does not always set COMSPEC, tramp blows up in a string-match) Date: Sun, 03 Apr 2016 19:17:29 +0300 Message-ID: <831t6mr7ja.fsf@gnu.org> References: <831t6nsyzy.fsf@gnu.org> <87a8lbpzbv.fsf@gmx.de> <83d1q6rbdu.fsf@gnu.org> <87a8laoff2.fsf@gmx.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459700363 16130 80.91.229.3 (3 Apr 2016 16:19:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Apr 2016 16:19:23 +0000 (UTC) Cc: ja2038@gmail.com, 23186@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 03 18:19:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1amkk4-0003Pa-R3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Apr 2016 18:19:12 +0200 Original-Received: from localhost ([::1]:54264 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amkk4-0000H8-AG for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Apr 2016 12:19:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amkjz-0000Eq-6j for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 12:19:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amkju-0000tY-KV for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 12:19:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amkju-0000tT-Gi for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 12:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1amkju-0000RZ-D8 for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 12:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Apr 2016 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23186-submit@debbugs.gnu.org id=B23186.14597002881638 (code B ref 23186); Sun, 03 Apr 2016 16:19:02 +0000 Original-Received: (at 23186) by debbugs.gnu.org; 3 Apr 2016 16:18:08 +0000 Original-Received: from localhost ([127.0.0.1]:50126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amkj2-0000QM-Gm for submit@debbugs.gnu.org; Sun, 03 Apr 2016 12:18:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amkj1-0000QB-Ru for 23186@debbugs.gnu.org; Sun, 03 Apr 2016 12:18:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amkis-0000a5-9Q for 23186@debbugs.gnu.org; Sun, 03 Apr 2016 12:18:02 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amkis-0000a0-67; Sun, 03 Apr 2016 12:17:58 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3408 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1amkir-0003Cz-D6; Sun, 03 Apr 2016 12:17:57 -0400 In-reply-to: <87a8laoff2.fsf@gmx.de> (message from Michael Albinus on Sun, 03 Apr 2016 17:55:29 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115939 Archived-At: > From: Michael Albinus > Cc: ja2038@gmail.com, 23186@debbugs.gnu.org > Date: Sun, 03 Apr 2016 17:55:29 +0200 > > > Can you (Michael) explain why does Tramp need this variable, and also > > why it needs the companion tramp-encoding-command-switch? Why not > > just use shell-file-name and shell-command-switch? Or, if you must > > look deeper, why not call w32-shell-name or w32-shell-dos-semantics? > > I think these already do what you need tramp-encoding-shell for, but > > maybe I'm missing something. > > Well, this is set this way for decades. I don't remember the datails; > likely it was used also for other cases than just local encoding/ > decoding. And don't forget, Tramp has carried a lot of compat code, back > to Emacs 21 and XEmacs. Maybe it was not possible to trust on `w32-shell-name'. I figured it was something like that. > This compat code has been removed recently. So it is applicable indeed, > to use `w32-shell-name'. I've committed a patch to master, doing this. I > don't know, whether the setting for `tramp-encoding-command-switch' is > OK, 'tho. The beauty of w32-shell-name is that you don't need to worry about the switch: cmdproxy supports both -c and /c (and even -C and /C). So you can now safely use just "-c" for tramp-encoding-command-switch. Or, if you want to be extra-cautious, and protect Tramp from people who point shell-file-name or $SHELL at something weird, you can use w32-shell-dos-semantics: if it returns non-nil, use /c, otherwise -c. > As usual, I cannot test it for w32. Let's see, whether we get reports :-) Yep. Thanks.