From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS) Date: Wed, 25 May 2016 19:26:06 +0300 Message-ID: <831t4q3y01.fsf@gnu.org> References: <87bn3z4l9i.fsf@mat.ucm.es> <1444321464004323@web25h.yandex.ru> <83h9do67pp.fsf@gnu.org> <21f6198c-a2fc-365f-caf7-79fad5027f1c@yandex.ru> <83twho41xd.fsf@gnu.org> <574543D5.1030201@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1464193649 2698 80.91.229.3 (25 May 2016 16:27:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 May 2016 16:27:29 +0000 (UTC) Cc: oub@mat.ucm.es, dgutov@yandex.ru, 23595@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 25 18:27:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b5beO-0006KS-VK for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 May 2016 18:27:17 +0200 Original-Received: from localhost ([::1]:33957 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5beK-0004oY-LL for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 May 2016 12:27:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5beC-0004o7-6V for bug-gnu-emacs@gnu.org; Wed, 25 May 2016 12:27:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5beA-0000ub-1Y for bug-gnu-emacs@gnu.org; Wed, 25 May 2016 12:27:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5be9-0000uX-Ub for bug-gnu-emacs@gnu.org; Wed, 25 May 2016 12:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b5be9-0002Xi-QJ for bug-gnu-emacs@gnu.org; Wed, 25 May 2016 12:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2016 16:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23595 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23595-submit@debbugs.gnu.org id=B23595.14641935749716 (code B ref 23595); Wed, 25 May 2016 16:27:01 +0000 Original-Received: (at 23595) by debbugs.gnu.org; 25 May 2016 16:26:14 +0000 Original-Received: from localhost ([127.0.0.1]:38478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5bdO-0002We-74 for submit@debbugs.gnu.org; Wed, 25 May 2016 12:26:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5bdN-0002WS-1M for 23595@debbugs.gnu.org; Wed, 25 May 2016 12:26:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5bdD-0000i3-Kx for 23595@debbugs.gnu.org; Wed, 25 May 2016 12:26:07 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5bdD-0000hp-HM; Wed, 25 May 2016 12:26:03 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1402 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b5bdB-0001ta-Gx; Wed, 25 May 2016 12:26:01 -0400 In-reply-to: <574543D5.1030201@cs.ucla.edu> (message from Paul Eggert on Tue, 24 May 2016 23:19:01 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118662 Archived-At: > Cc: oub@mat.ucm.es, 23595@debbugs.gnu.org > From: Paul Eggert > Date: Tue, 24 May 2016 23:19:01 -0700 > > ascii-compatible-p is not the right test, > the right one is mime-text-unsuitable-p; and the test should be > reversed, i.e. this: > > (coding-system-get CODING-SYSTEM :mime-text-unsuitable-p) > > should return nil for CODING-SYSTEM to be usable. > > Better, but this wouldn't work for coding systems like ebcdic-us, which are so incompatible with ASCII that messages like "Binary files differ" would turn into gibberish. It's easy enough to exempt EBCDIC (and any other similar encodings). There are only 3 of them, AFAICS. > We could establish a new coding system property for "close enough to ASCII that most people won't mind". That would be a more-intrusive change, though. For emacs-25 I thought it'd be better to have something that is more self-contained. A :mime-text-unsuitable-p test augmented by a list of additional coding-systems we find unsuitable is simple, self-contained, and safe for emacs-25, IMO. For master, we could add a cleaner, but more intrusive fix.