From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: oub@mat.ucm.es, dgutov@yandex.ru, 23595@debbugs.gnu.org
Subject: bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS)
Date: Wed, 25 May 2016 19:26:06 +0300 [thread overview]
Message-ID: <831t4q3y01.fsf@gnu.org> (raw)
In-Reply-To: <574543D5.1030201@cs.ucla.edu> (message from Paul Eggert on Tue, 24 May 2016 23:19:01 -0700)
> Cc: oub@mat.ucm.es, 23595@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue, 24 May 2016 23:19:01 -0700
>
> ascii-compatible-p is not the right test,
> the right one is mime-text-unsuitable-p; and the test should be
> reversed, i.e. this:
>
> (coding-system-get CODING-SYSTEM :mime-text-unsuitable-p)
>
> should return nil for CODING-SYSTEM to be usable.
>
> Better, but this wouldn't work for coding systems like ebcdic-us, which are so incompatible with ASCII that messages like "Binary files differ" would turn into gibberish.
It's easy enough to exempt EBCDIC (and any other similar encodings).
There are only 3 of them, AFAICS.
> We could establish a new coding system property for "close enough to ASCII that most people won't mind". That would be a more-intrusive change, though. For emacs-25 I thought it'd be better to have something that is more self-contained.
A :mime-text-unsuitable-p test augmented by a list of additional
coding-systems we find unsuitable is simple, self-contained, and safe
for emacs-25, IMO. For master, we could add a cleaner, but more
intrusive fix.
next prev parent reply other threads:[~2016-05-25 16:26 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 13:02 bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS) Uwe Brauer
2016-05-23 11:52 ` Dmitry Gutov
2016-05-23 12:41 ` Uwe Brauer
2016-05-23 13:17 ` Dmitry Gutov
2016-05-23 16:52 ` Eli Zaretskii
2016-05-23 16:51 ` Eli Zaretskii
2016-05-23 16:48 ` Eli Zaretskii
2016-05-23 17:00 ` Uwe Brauer
2016-05-23 17:31 ` Eli Zaretskii
2016-05-23 20:37 ` Uwe Brauer
2016-05-23 21:01 ` Lars Ingebrigtsen
2016-05-24 2:33 ` Eli Zaretskii
2016-05-23 21:02 ` Dmitry Gutov
2016-05-23 22:16 ` Paul Eggert
2016-05-23 22:28 ` Dmitry Gutov
2016-05-24 0:07 ` Paul Eggert
2016-05-24 9:47 ` Dmitry Gutov
2016-05-25 6:51 ` Paul Eggert
2016-05-25 12:44 ` Dmitry Gutov
2016-05-25 12:48 ` Overriding the value of indent-tabs-mode in Emacs code Dmitry Gutov
2016-05-25 21:44 ` Paul Eggert
2016-05-25 22:00 ` Dmitry Gutov
2016-05-25 22:11 ` Paul Eggert
2016-05-25 22:18 ` Dmitry Gutov
2016-05-25 22:36 ` Paul Eggert
2016-05-25 22:47 ` Dmitry Gutov
2016-05-25 23:24 ` Michael Heerdegen
2016-05-25 23:30 ` Dmitry Gutov
2016-05-25 23:54 ` Stefan Monnier
2016-05-26 10:59 ` Dmitry Gutov
2016-05-26 12:18 ` Stefan Monnier
2016-05-27 19:45 ` John Wiegley
2016-05-27 19:50 ` Stefan Monnier
2016-05-27 20:19 ` Paul Eggert
2016-05-27 20:53 ` John Wiegley
2016-05-26 0:00 ` Michael Heerdegen
2016-05-25 23:40 ` Karl Fogel
2016-05-26 0:02 ` Michael Heerdegen
2016-05-24 2:40 ` bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS) Eli Zaretskii
2016-05-24 15:36 ` Eli Zaretskii
2016-05-24 2:36 ` Eli Zaretskii
2016-05-24 9:35 ` Dmitry Gutov
2016-05-24 15:40 ` Eli Zaretskii
2016-05-25 0:09 ` Dmitry Gutov
2016-05-25 16:22 ` Eli Zaretskii
2016-05-25 23:21 ` Dmitry Gutov
2016-05-26 10:44 ` Uwe Brauer
2016-05-26 15:35 ` Eli Zaretskii
2016-06-19 19:09 ` Dmitry Gutov
2016-05-25 6:19 ` Paul Eggert
2016-05-25 16:27 ` Eli Zaretskii
2016-05-25 6:19 ` Paul Eggert
2016-05-25 16:26 ` Eli Zaretskii [this message]
2016-05-23 17:40 ` Paul Eggert
2016-05-23 18:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831t4q3y01.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23595@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=oub@mat.ucm.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.