From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23600: 25.1.50; encode-time returns wrong result Date: Sun, 05 Jun 2016 18:20:04 +0300 Message-ID: <831t4bvf17.fsf@gnu.org> References: <574E9AA6.1070606@cs.ucla.edu> <83h9d9uf3d.fsf@gnu.org> <57530C98.3030508@cs.ucla.edu> <838tykvort.fsf@gnu.org> <575353C3.7090203@cs.ucla.edu> <8337osuzb4.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1465140034 2079 80.91.229.3 (5 Jun 2016 15:20:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 5 Jun 2016 15:20:34 +0000 (UTC) Cc: kzhr@d1.dion.ne.jp, 23600@debbugs.gnu.org To: eggert@cs.ucla.edu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 05 17:20:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b9ZqX-0000sp-Ef for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jun 2016 17:20:13 +0200 Original-Received: from localhost ([::1]:37537 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9ZqW-0004m4-Jb for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Jun 2016 11:20:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9ZqQ-0004jn-Cn for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 11:20:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9ZqM-0000eG-4s for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 11:20:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9ZqM-0000eC-1s for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 11:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b9ZqL-0000bX-Ue for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 11:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2016 15:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23600 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 23600-submit@debbugs.gnu.org id=B23600.14651399852296 (code B ref 23600); Sun, 05 Jun 2016 15:20:01 +0000 Original-Received: (at 23600) by debbugs.gnu.org; 5 Jun 2016 15:19:45 +0000 Original-Received: from localhost ([127.0.0.1]:55707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9Zq5-0000ay-85 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 11:19:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9Zq2-0000ak-Qk for 23600@debbugs.gnu.org; Sun, 05 Jun 2016 11:19:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9Zpu-0000be-AL for 23600@debbugs.gnu.org; Sun, 05 Jun 2016 11:19:37 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9Zpu-0000bX-7U; Sun, 05 Jun 2016 11:19:34 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3354 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9Zps-0004kB-FM; Sun, 05 Jun 2016 11:19:33 -0400 In-reply-to: <8337osuzb4.fsf@gnu.org> (message from Eli Zaretskii on Sun, 05 Jun 2016 05:47:27 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119108 Archived-At: > Date: Sun, 05 Jun 2016 05:47:27 +0300 > From: Eli Zaretskii > Cc: kzhr@d1.dion.ne.jp, 23600@debbugs.gnu.org > > > Cc: kzhr@d1.dion.ne.jp, 23600@debbugs.gnu.org > > From: Paul Eggert > > Date: Sat, 4 Jun 2016 15:18:43 -0700 > > > > Eli Zaretskii wrote: > > > I think it would be cleaner if we copied the string before modifying > > > it. > > > > Other parts of Emacs modify the string in place and expect the modifications to > > affect the time zone setting, so in general it won't work to copy the string, > > modify the copy, and pass the copy's address to putenv. > > Too bad. Actually, could you point me to those places? Because if the code which expects that is not already ifdef'ed out/around for Windows, it's a problem waiting to be discovered, since MS _putenv accepts a 'const char *' argument, and my references indicate that the implementation indeed copies the input string. So those other parts of the code expect something that cannot work on Windows. Thanks.