From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env Date: Sun, 19 Jun 2016 18:01:13 +0300 Message-ID: <831t3t9q9y.fsf@gnu.org> References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <57660314.9050907@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1466348485 16663 80.91.229.3 (19 Jun 2016 15:01:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 19 Jun 2016 15:01:25 +0000 (UTC) Cc: 23779@debbugs.gnu.org, schwab@linux-m68k.org, dgutov@yandex.ru, npostavs@users.sourceforge.net To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 19 17:01:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bEeDp-0007H2-9R for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Jun 2016 17:01:13 +0200 Original-Received: from localhost ([::1]:38975 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEeDo-0005MZ-Ev for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Jun 2016 11:01:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEeDi-0005MT-Hq for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2016 11:01:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEeDe-0002DX-CM for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2016 11:01:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEeDe-0002DS-8d for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2016 11:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bEeDd-0001pQ-Vb for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2016 11:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jun 2016 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23779-submit@debbugs.gnu.org id=B23779.14663484206968 (code B ref 23779); Sun, 19 Jun 2016 15:01:01 +0000 Original-Received: (at 23779) by debbugs.gnu.org; 19 Jun 2016 15:00:20 +0000 Original-Received: from localhost ([127.0.0.1]:46556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEeCx-0001oJ-Pa for submit@debbugs.gnu.org; Sun, 19 Jun 2016 11:00:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEeCx-0001o8-7g for 23779@debbugs.gnu.org; Sun, 19 Jun 2016 11:00:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEeCo-0001vH-Pt for 23779@debbugs.gnu.org; Sun, 19 Jun 2016 11:00:13 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEeCo-0001uT-MZ; Sun, 19 Jun 2016 11:00:10 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2581 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bEeCl-000553-OM; Sun, 19 Jun 2016 11:00:08 -0400 In-reply-to: <57660314.9050907@cs.ucla.edu> (message from Paul Eggert on Sun, 19 Jun 2016 04:27:32 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119775 Archived-At: > Cc: npostavs@users.sourceforge.net, 23779@debbugs.gnu.org > From: Paul Eggert > Date: Sun, 19 Jun 2016 04:27:32 +0200 > > On 06/17/2016 04:19 PM, Eli Zaretskii wrote: > >> Looks like it does. Please push at your convenience. > > I'd like the patch to be eyeballed by a few more people. Paul, > > Andreas, do you see any problems with it? If not, I'd like to push it > > to the emacs-25 branch > The patch is correct. Thanks for the review. I will push the patch soon to emacs-25. > The code is tricky so I'm not surprised you wanted another pair of > eyes. Indeed. > The attached patch is a very minor tweak of your > patch that made it a bit easier for me to follow. I think I will go with my version, mainly because it will most probably be short-lived, and so is not worth optimizing. > I resisted the temptation of cleaning up the surrounding code to > make it more readable. Feel free to do that on master; I can mark the emacs-25 fix "not to be merged".