From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string. Date: Sat, 10 Sep 2016 08:42:35 +0300 Message-ID: <831t0s9upg.fsf@gnu.org> References: <20160907153014.15752-1-toke@toke.dk> <87inu7k5z4.fsf@toke.dk> <83bmzzaawr.fsf@gnu.org> <877fank1oc.fsf@toke.dk> <87inu6iim8.fsf@toke.dk> <2563921f-d20d-753b-09eb-c8671bc5b6d6@yandex.ru> <87a8fiidso.fsf@toke.dk> <86d1kdq7cs.fsf@realize.ch> <83bmzwaopr.fsf@gnu.org> <8660q4ria9.fsf@realize.ch> <8360q4amyx.fsf@gnu.org> <861t0srh2s.fsf@realize.ch> <8337l8am6k.fsf@gnu.org> <87k2ek7soz.fsf@toke.dk> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1473486208 3404 195.159.176.226 (10 Sep 2016 05:43:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Sep 2016 05:43:28 +0000 (UTC) Cc: a.s@realize.ch, emacs-devel@gnu.org, monnier@iro.umontreal.ca, dgutov@yandex.ru To: Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 10 07:43:23 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bib4R-0008KG-Jq for ged-emacs-devel@m.gmane.org; Sat, 10 Sep 2016 07:43:19 +0200 Original-Received: from localhost ([::1]:33284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bib4O-00029r-GZ for ged-emacs-devel@m.gmane.org; Sat, 10 Sep 2016 01:43:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bib3s-00028s-0R for emacs-devel@gnu.org; Sat, 10 Sep 2016 01:42:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bib3n-0002Ga-Sy for emacs-devel@gnu.org; Sat, 10 Sep 2016 01:42:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bib3n-0002GN-QE; Sat, 10 Sep 2016 01:42:39 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1726 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bib3l-0001D1-MI; Sat, 10 Sep 2016 01:42:38 -0400 In-reply-to: <87k2ek7soz.fsf@toke.dk> (message from Toke =?iso-8859-1?Q?H?= =?iso-8859-1?Q?=F8iland-J=F8rgensen?= on Fri, 09 Sep 2016 21:56:44 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207348 Archived-At: > From: Toke Høiland-Jørgensen > Cc: Alain Schneble , dgutov@yandex.ru, monnier@iro.umontreal.ca, > emacs-devel@gnu.org > Date: Fri, 09 Sep 2016 21:56:44 +0200 > > > It wouldn't be safe if cookies could include non-ASCII characters. > > Well, according to this: > > http://stackoverflow.com/a/1969339 > > Safari, at least, will reject non-ASCII cookies. Which implies that in > practice no sites will use non-ASCII values because they would break. Then your original patch should be fine for the emacs-25 branch. If no objections are voiced here by the end of the day, I think we should install it. Thanks.