From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Some proposed backports from master to emacs-25 Date: Sun, 02 Oct 2016 17:54:54 +0300 Message-ID: <831szyrebl.fsf@gnu.org> References: <87shseyhfl.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1475420149 28377 195.159.176.226 (2 Oct 2016 14:55:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Oct 2016 14:55:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: npostavs@users.sourceforge.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 02 16:55:43 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqiAt-0005Me-Ud for ged-emacs-devel@m.gmane.org; Sun, 02 Oct 2016 16:55:32 +0200 Original-Received: from localhost ([::1]:59730 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqiAs-0002DH-LN for ged-emacs-devel@m.gmane.org; Sun, 02 Oct 2016 10:55:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqiAH-0002DB-Dz for emacs-devel@gnu.org; Sun, 02 Oct 2016 10:54:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqiAB-0001Kx-Gt for emacs-devel@gnu.org; Sun, 02 Oct 2016 10:54:52 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqiAB-0001Kb-Do; Sun, 02 Oct 2016 10:54:47 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4046 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bqiA9-0000ah-96; Sun, 02 Oct 2016 10:54:46 -0400 In-reply-to: <87shseyhfl.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207938 Archived-At: > From: npostavs@users.sourceforge.net > Date: Sun, 02 Oct 2016 10:05:50 -0400 > > I had marked some bugs as fixed in 25.2 and pushed to master because I > didn't know at the time it was going to be 26. I think there were some > others working under the same assumption, so I've gathered those fixes > to backport in a semi-automated fashion by searching commit messages in > the range emacs-25..master for non-wishlist bugs marked fixed in 25.2, Could you please provide a short explanation why you think each of the backports should be in 25.2? I've looked through the log messages, and couldn't figure that out easily. In general, since we want 25.2 released quickly, I think the criteria for back-porting should be somewhat rigid, something like: . any doc fixes . regressions from 24.5 . problems introduced in features new in 25.1 > (defvar backporting-fixed-bug-list > (debbugs-get-bugs :status "done" :tag "fixed" > :archive "both")) > > (defvar backporting-fixed-bug-status-list > (apply #'debbugs-get-status backporting-fixed-bug-list)) > > (defun backporting-fixed-25.2-bug-list () > (cl-loop for bug in backporting-fixed-bug-status-list > if (and (member "25.2" (cdr (assq 'fixed_versions bug))) > (not (equal "wishlist" (cdr (assq 'severity bug))))) > collect (cdr (assq 'id bug)))) That looks quite a bit more than the above criteria, but maybe I'm missing something. Thanks.