From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25215: 25.1.90; js--proper-indentation is affected by the value of forward-sexp-function Date: Fri, 16 Dec 2016 23:02:38 +0200 Message-ID: <831sx78u4x.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1481922273 1559 195.159.176.226 (16 Dec 2016 21:04:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Dec 2016 21:04:33 +0000 (UTC) Cc: 25215@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 16 22:04:27 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHzg1-0007Wv-VZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Dec 2016 22:04:26 +0100 Original-Received: from localhost ([::1]:34289 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHzg6-000611-C5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Dec 2016 16:04:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHzfi-0004a7-CI for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2016 16:04:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHzff-0006mK-8q for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2016 16:04:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cHzff-0006m5-6q for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2016 16:04:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cHzfe-0004hT-AX for bug-gnu-emacs@gnu.org; Fri, 16 Dec 2016 16:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2016 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25215-submit@debbugs.gnu.org id=B25215.148192220618023 (code B ref 25215); Fri, 16 Dec 2016 21:04:02 +0000 Original-Received: (at 25215) by debbugs.gnu.org; 16 Dec 2016 21:03:26 +0000 Original-Received: from localhost ([127.0.0.1]:44589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHzf3-0004gc-MQ for submit@debbugs.gnu.org; Fri, 16 Dec 2016 16:03:25 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:43478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHzf2-0004gR-3S for 25215@debbugs.gnu.org; Fri, 16 Dec 2016 16:03:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHzev-0006RL-VQ for 25215@debbugs.gnu.org; Fri, 16 Dec 2016 16:03:18 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHzev-0006RH-Sf; Fri, 16 Dec 2016 16:03:17 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3071 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cHzev-0002z8-8V; Fri, 16 Dec 2016 16:03:17 -0500 In-reply-to: (message from Dmitry Gutov on Fri, 16 Dec 2016 14:58:35 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127096 Archived-At: > From: Dmitry Gutov > Date: Fri, 16 Dec 2016 14:58:35 +0200 > > js2-mode derives from js-mode and, starting with Emacs 25.1, inherits > its indentation function. > > However, forward-sexp-function in js2-mode can be slow because it uses > the AST, and when the current parsing pass had been interrupted by user > input, it's forced to finish. Which is slow in large files. > > And its subtleties aren't really needed by the intentation code. So in > the various bits of code we've brought over from js2-mode we have kept > the forward-sexp-function->nil binding. > > We've missed it in js--multi-line-declaration-indentation, hovewer. And > in js--maybe-goto-declaration-keyword-end (though that one only comes > into play with a non-default value of js-indent-first-init). > > The patch is below. Thanks, this is okay for the release branch.