From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Reformat all of src/ Date: Thu, 29 Dec 2016 18:15:48 +0200 Message-ID: <831swqvhhn.fsf@gnu.org> References: <87h95olvg0.fsf@gmail.com> <83eg0rv1up.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1483028214 27783 195.159.176.226 (29 Dec 2016 16:16:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2016 16:16:54 +0000 (UTC) Cc: jwiegley@gmail.com, czipperz@gmail.com, rms@gnu.org, emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 17:16:49 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cMdNj-0005wC-Lm for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2016 17:16:43 +0100 Original-Received: from localhost ([::1]:36224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMdNo-0001RY-Aa for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2016 11:16:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMdN7-0001QU-EH for emacs-devel@gnu.org; Thu, 29 Dec 2016 11:16:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cMdN2-0005EZ-0m for emacs-devel@gnu.org; Thu, 29 Dec 2016 11:16:05 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cMdN1-0005EU-TR; Thu, 29 Dec 2016 11:15:59 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1276 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cMdMu-0005OX-AT; Thu, 29 Dec 2016 11:15:52 -0500 In-reply-to: (message from Tino Calancha on Thu, 29 Dec 2016 21:04:13 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210956 Archived-At: > From: Tino Calancha > Date: Thu, 29 Dec 2016 21:04:13 +0900 (JST) > cc: rms@gnu.org, jwiegley@gmail.com, czipperz@gmail.com, emacs-devel@gnu.org > > > We arrived at the current convention of not doing such changes unless > > real code changes are also committed based on our practice, so I don't > > think we should reverse that decision. > Is just a voluntary convention? Is is prefered or discouraged? I think you will generally get responses such as you've seen for any patch suggestion that only changes whitespace. > If the former, then we might encourage it adding some instructions > in CONTRIBUTE about when/how do this thing. It probably should be in CONTRIBUTE, yes. I think the reason it isn't is that this issue doesn't pop up too frequently. > When i am changing a function which uses tabs for indentation, i > think that is a good opportunity to change such func. to use white > spaces instead. That is a separate issue: whether C sources should use the default TABs and SPACEs indentation or just SPACEs. I think we agreed to disagree about that, and that's why .dir-locals.el doesn't say anything about the C mode, so that everyone could use the settings they have in their .emacs.