From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: dired-tests.el fails on MS-Windows Date: Fri, 04 Aug 2017 16:14:18 +0300 Message-ID: <831sorxyol.fsf@gnu.org> References: <83zibjz519.fsf@gnu.org> <87d18fw79z.fsf@calancha-pc> <83pocfyurp.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1501855756 18352 195.159.176.226 (4 Aug 2017 14:09:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 Aug 2017 14:09:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 04 16:09:12 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dddHm-0004JG-Px for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 16:09:06 +0200 Original-Received: from localhost ([::1]:53928 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dddHs-0001Jd-Lu for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 10:09:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddcS0-0000mK-FD for emacs-devel@gnu.org; Fri, 04 Aug 2017 09:16:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddcQw-0003n7-76 for emacs-devel@gnu.org; Fri, 04 Aug 2017 09:15:36 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddcQv-0003mn-V9; Fri, 04 Aug 2017 09:14:30 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4512 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ddcQv-0002OF-79; Fri, 04 Aug 2017 09:14:29 -0400 In-reply-to: (message from Tino Calancha on Fri, 4 Aug 2017 14:21:01 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217284 Archived-At: > From: Tino Calancha > Date: Fri, 4 Aug 2017 14:21:01 +0900 (JST) > cc: Tino Calancha , > Emacs developers > > > maybe if you could explain the idea behind the code I could think of a > > reason why it doesn't work here. > I added more comments and sanity checks in commit > db5d38ddb0de83d8f920b7a128fe3fd5156fdf85 > (Fix 2 tests that fail in MS-Windows) > Does it work now in Windows? It didn't, but given the comments I've now succeeded to understand the idea of dired-test-bug25609, and fixed it. dired-test-bug27631 still fails, and it fails because of this: (setq buf (dired (expand-file-name "dir*/*.txt" dir))) ls-lisp signals an error here: wrong-type-argument listp "dir*/*.txt" Didn't you add a feature lately that should support this in ls-lisp? I guess that feature needs to be turned on for this test to pass on Windows.