From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Suspicious warning in W64 build Date: Fri, 08 Sep 2017 11:02:39 +0300 Message-ID: <831snhzkgw.fsf@gnu.org> References: <1017454172.910810.1504618695244@mail.libero.it> <83tw0ezgi1.fsf@gnu.org> <1146932094.13821.1504798935795@mail.libero.it> <83mv66z66p.fsf@gnu.org> <102a4c21-c275-c73e-ec53-0d85975dc968@cs.ucla.edu> <83a825znuf.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1504857805 20654 195.159.176.226 (8 Sep 2017 08:03:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Sep 2017 08:03:25 +0000 (UTC) Cc: eggert@cs.ucla.edu, angelo.g0@libero.it, emacs-devel@gnu.org To: rcopley@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 08 10:03:06 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqEFX-0003tW-Tg for ged-emacs-devel@m.gmane.org; Fri, 08 Sep 2017 10:02:52 +0200 Original-Received: from localhost ([::1]:43792 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqEFe-0008CZ-OZ for ged-emacs-devel@m.gmane.org; Fri, 08 Sep 2017 04:02:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqEFQ-00087e-B2 for emacs-devel@gnu.org; Fri, 08 Sep 2017 04:02:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqEFF-0004Ky-Nc for emacs-devel@gnu.org; Fri, 08 Sep 2017 04:02:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqEFF-0004Kp-Kx; Fri, 08 Sep 2017 04:02:33 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3256 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dqEFE-0000oB-QQ; Fri, 08 Sep 2017 04:02:33 -0400 In-reply-to: <83a825znuf.fsf@gnu.org> (message from Eli Zaretskii on Fri, 08 Sep 2017 09:49:44 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218008 Archived-At: > Date: Fri, 08 Sep 2017 09:49:44 +0300 > From: Eli Zaretskii > Cc: eggert@cs.ucla.edu, angelo.g0@libero.it, emacs-devel@gnu.org > > > From: Richard Copley > > Date: Thu, 7 Sep 2017 21:02:05 +0100 > > Cc: Eli Zaretskii , Angelo Graziosi , > > Emacs Development > > > > On 7 September 2017 at 20:26, Paul Eggert wrote: > > > Try putting an 'eassume (0 <= nglyphs);' before the line in question. > > > > The warning goes away. > > OK, I will commit that change, then. Done. > > By the way, there's another warning which is both true and easy to fix. > > "(1 << ((n) % 32)))" should read "(1u << ((n) % 32)))" on line 2191. > > > > CC w32font.o > > w32font.c: In function 'font_supported_scripts': > > w32font.c:2191:32: warning: result of '1 << 31' requires 33 bits to > > represent, but 'int' only has 32 bits [-Wshift-overflow=] > > if (subranges[(n) / 32] & (1 << ((n) % 32))) \ > > ^ > > w32font.c:2246:3: note: in expansion of macro 'SUBRANGE' > > SUBRANGE (31, Qsymbol); > > ^~~~~~~~ > > w32font.c:2191:32: warning: result of '1 << 31' requires 33 bits to > > represent, but 'int' only has 32 bits [-Wshift-overflow=] > > if (subranges[(n) / 32] & (1 << ((n) % 32))) \ > > ^ > > w32font.c:2308:3: note: in expansion of macro 'SUBRANGE' > > SUBRANGE (95, Qtai_le); > > ^~~~~~~~ > > Yes, I've seen this and have a fix for it. Pushed to master.