From: Eli Zaretskii <eliz@gnu.org>
To: Fabrice Popineau <fabrice.popineau@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs master, security concernes, ms-windows
Date: Thu, 14 Sep 2017 20:08:30 +0300 [thread overview]
Message-ID: <831sn9nr75.fsf@gnu.org> (raw)
In-Reply-To: <CAFgFV9PEF0BA_VQx9EYXmx5=e3v5arr8oBBHfdp7OaqCF0Ny8Q@mail.gmail.com> (message from Fabrice Popineau on Thu, 14 Sep 2017 09:58:36 +0200)
> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Thu, 14 Sep 2017 09:58:36 +0200
>
> Since there seems to be a lot of concerns wrt to security,
> I am submitting the attached patch.
>
> The reason for this patch is to limit the search for dlls loaded at
> runtime to the win32 system directory and/or the emacs application
> directory.
> In the current state, dlls can be picked up in any directory in the path.
> Some one could fake one of these dlls (xpm, png, etc.) and use it for
> mean reasons.
I see your point, and I'm sympathetic to the concerns. However, given
the accepted practices of installing packages on Windows, I don't
think we can do this by default. Many times people install optional
libraries in separate directories and just add them to PATH. Some
even install each individual package into its own directory. I just
had a conversation off-list with one such user. Disabling DLL look up
on PATH by default will completely screw up those users.
In addition, as others pointed out, this mode is not supported before
Vista, so we shouldn't pass that constant to LoadLibraryEx on systems
that don't support it, even if we accept such a feature as an optional
one.
Thanks.
prev parent reply other threads:[~2017-09-14 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 7:58 Emacs master, security concernes, ms-windows Fabrice Popineau
2017-09-14 13:33 ` Óscar Fuentes
2017-09-14 13:46 ` Fabrice Popineau
2017-09-14 15:20 ` Óscar Fuentes
2017-09-14 15:56 ` Fabrice Popineau
2017-09-14 17:27 ` Eli Zaretskii
2017-09-14 17:24 ` Eli Zaretskii
2017-09-14 17:18 ` Eli Zaretskii
2017-09-14 14:13 ` Andy Moreton
2017-09-14 17:08 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831sn9nr75.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=fabrice.popineau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.