From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: 29712@debbugs.gnu.org
Subject: bug#29712: 26.0.90; Three emacs-26 elisp tests are failing on darwin
Date: Sat, 16 Dec 2017 18:47:00 +0200 [thread overview]
Message-ID: <831sjusjqz.fsf@gnu.org> (raw)
In-Reply-To: <20171216164218.GA57819@breton.holly.idiocy.org> (message from Alan Third on Sat, 16 Dec 2017 16:42:18 +0000)
> Date: Sat, 16 Dec 2017 16:42:18 +0000
> From: Alan Third <alan@idiocy.org>
> Cc: 29712@debbugs.gnu.org
>
> modified lisp/term/ns-win.el
> @@ -354,7 +354,7 @@ ns-delete-working-text
> ;; Used prior to Emacs 25.
> (define-coding-system-alias 'utf-8-nfd 'utf-8-hfs)
>
> - (set-file-name-coding-system 'utf-8-hfs))
> + (set-file-name-coding-system 'utf-8-hfs-unix))
>
> ;;;; Inter-app communications support.
Such a change is OK for master (assuming I understood you correctly,
and the current master doesn't have anything equivalent to the above).
On the release branch, I'd suggest to bind file-name-coding-system to
utf-8-hfs-unix, and tell in the commit log message not to merge to
master.
> I made the change and everything looks ok; the other tests still pass.
> I don’t know anything about coding systems, though, so I could be
> missing something.
I don't think you need to fear anything. It's the right thing to do
on systems that allow CR in file names.
Thanks.
next prev parent reply other threads:[~2017-12-16 16:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 16:46 bug#29712: 26.0.90; Three emacs-26 elisp tests are failing on darwin John Wiegley
2017-12-15 8:39 ` Michael Albinus
2017-12-16 1:02 ` Alan Third
2017-12-16 10:23 ` Michael Albinus
2017-12-16 13:47 ` Alan Third
2017-12-16 15:55 ` Michael Albinus
2017-12-16 1:10 ` Alan Third
2017-12-16 8:34 ` Eli Zaretskii
2017-12-16 9:46 ` Alan Third
2017-12-16 10:35 ` Eli Zaretskii
2017-12-16 13:42 ` Alan Third
2017-12-16 14:15 ` Eli Zaretskii
2017-12-16 15:07 ` Alan Third
2017-12-16 16:19 ` Eli Zaretskii
2017-12-16 16:42 ` Alan Third
2017-12-16 16:47 ` Eli Zaretskii [this message]
2017-12-16 17:01 ` Alan Third
2017-12-16 17:19 ` Eli Zaretskii
2018-01-08 21:16 ` John Wiegley
2018-01-10 0:12 ` Alan Third
2018-01-29 18:43 ` John Wiegley
2018-01-30 21:44 ` Alan Third
2018-01-30 22:40 ` John Wiegley
2018-01-31 20:03 ` Alan Third
2018-02-01 18:05 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831sjusjqz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=29712@debbugs.gnu.org \
--cc=alan@idiocy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.