From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: gnus-cloud native GnuTLS AEAD support Date: Fri, 22 Dec 2017 16:05:17 +0200 Message-ID: <831sjmn9ia.fsf@gnu.org> References: <87a7yl51r1.fsf@lifelogs.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1513951428 11819 195.159.176.226 (22 Dec 2017 14:03:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Dec 2017 14:03:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 22 15:03:44 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eSNvJ-0002Wp-Us for ged-emacs-devel@m.gmane.org; Fri, 22 Dec 2017 15:03:42 +0100 Original-Received: from localhost ([::1]:51868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSNxG-00057w-Q1 for ged-emacs-devel@m.gmane.org; Fri, 22 Dec 2017 09:05:42 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSNwy-00053X-Vi for emacs-devel@gnu.org; Fri, 22 Dec 2017 09:05:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eSNwu-0004Jo-8v for emacs-devel@gnu.org; Fri, 22 Dec 2017 09:05:24 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eSNwu-0004JU-52; Fri, 22 Dec 2017 09:05:20 -0500 Original-Received: from [176.228.60.248] (port=2109 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eSNwt-00013S-G1; Fri, 22 Dec 2017 09:05:20 -0500 In-reply-to: <87a7yl51r1.fsf@lifelogs.com> (message from Ted Zlatanov on Thu, 14 Dec 2017 00:15:14 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221336 Archived-At: > From: Ted Zlatanov > Date: Thu, 14 Dec 2017 00:15:14 -0500 > > I've pushed scratch/tzz/gnus-cloud-aead with a proposed implementation > to use the native GnuTLS AEAD symmetric ciphers for gnus-cloud storage. > While this specifically is for IMAP articles, the implementation can > encrypt/decrypt any unibyte text data using AEAD ciphers. > > Reasons to implement it this way: > > * no dependency on external tools > * low risk: optional storage method for non-critical data > > TODO: > > * move the new code out to a library, either in core or in the GNU ELPA > * document, factor some things out > * add a checker function to read-passwd for min/max etc. requirements > > It worked well in my testing. Comments and suggestions welcome. Did you test this code with non-ASCII text? There are some tricky shenanigans with multibyte text in the associated gnutls.c functions, and you are using base64-encode-region, which will signal an error if any non-ASCII characters are found in the region it is invoked on. So I'd suggest to have that tested. And then there are the TODOs, of course. Thanks.