From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 0/1] Proper 24-bit TTY detection for Emacs 26. Date: Wed, 24 Jan 2018 20:39:47 +0200 Message-ID: <831sifnlsc.fsf@gnu.org> References: <20180123200536.26554-1-rami.ylimaki@vincit.fi> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1516819092 24500 195.159.176.226 (24 Jan 2018 18:38:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 Jan 2018 18:38:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Rami =?utf-8?Q?Ylim=C3=A4ki?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 24 19:38:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eePvt-0005i0-Fw for ged-emacs-devel@m.gmane.org; Wed, 24 Jan 2018 19:38:01 +0100 Original-Received: from localhost ([::1]:37669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eePxt-000478-NI for ged-emacs-devel@m.gmane.org; Wed, 24 Jan 2018 13:40:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eePxn-00046d-4Q for emacs-devel@gnu.org; Wed, 24 Jan 2018 13:39:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eePxi-0000K7-9d for emacs-devel@gnu.org; Wed, 24 Jan 2018 13:39:59 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eePxi-0000K1-6t; Wed, 24 Jan 2018 13:39:54 -0500 Original-Received: from [176.228.60.248] (port=2885 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eePxh-0001Yf-LO; Wed, 24 Jan 2018 13:39:54 -0500 In-reply-to: <20180123200536.26554-1-rami.ylimaki@vincit.fi> (message from Rami =?utf-8?Q?Ylim=C3=A4ki?= on Tue, 23 Jan 2018 22:05:35 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222193 Archived-At: > From: Rami Ylimäki > Date: Tue, 23 Jan 2018 22:05:35 +0200 > > Hi, I thought that it would make sense to fix this before official > release. Terminfo has just recently started to support capabilites for > detecting 24-bit terminals. It's too late to make incompatible changes on the emacs-26 branch. I actually don't understand the motivation for the change. Did the method we use now stop working in the recent versions of terminfo, and the "RGB" and "setaf"/"setab" replace "setf24"/"setb24" we use in the current code? Or are the new attributes supported in addition to the old ones? If the latter, why do we need to change anything? And if the former, I think we want to support both, not just the new replacements. Thanks.