From: Eli Zaretskii <eliz@gnu.org>
To: eggert@cs.ucla.edu
Cc: rgm@gnu.org, emacs-devel@gnu.org
Subject: Re: emacs-26 eec71eb: Speed up replace-buffer-contents
Date: Sat, 07 Jul 2018 14:57:34 +0300 [thread overview]
Message-ID: <831scfjm1d.fsf@gnu.org> (raw)
In-Reply-To: <8336wyone1.fsf@gnu.org> (message from Eli Zaretskii on Wed, 04 Jul 2018 21:40:22 +0300)
> Date: Wed, 04 Jul 2018 21:40:22 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: rgm@gnu.org, emacs-devel@gnu.org
>
> > Cc: rgm@gnu.org, emacs-devel@gnu.org
> > From: Paul Eggert <eggert@cs.ucla.edu>
> > Date: Wed, 4 Jul 2018 11:30:12 -0700
> >
> > If that's the case, there's still a performance bug in there. The point of
> > rarely_quit is to avoid calling maybe_quit in the vast majority of cases. If
> > maybe_quit is being called so often that it's a performance hog, then it's being
> > called too often.
>
> Maybe I'm mistaken, then. I will see what an optimized build shows.
Profiling the optimized build shows that 60% of the time is spent
inside buffer_chars_equal, and another 26% inside compareseq.
rarely_quit and maybe_quit are nowhere in sight in the profile.
And on my machine, the original recipe of bug#31888 completes in 2.5
sec of CPU time in the optimized build, which is "fast enough", IMO.
So I think we have no performance problem we need to fix, right?
next prev parent reply other threads:[~2018-07-07 11:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180629135646.6054.66405@vcs0.savannah.gnu.org>
[not found] ` <20180629135648.5C95A2053B@vcs0.savannah.gnu.org>
2018-07-03 2:25 ` emacs-26 eec71eb: Speed up replace-buffer-contents Glenn Morris
2018-07-03 6:25 ` Paul Eggert
2018-07-03 19:28 ` Eli Zaretskii
2018-07-03 20:14 ` Paul Eggert
2018-07-04 2:31 ` Eli Zaretskii
2018-07-04 6:36 ` Paul Eggert
2018-07-04 15:09 ` Eli Zaretskii
2018-07-04 18:30 ` Paul Eggert
2018-07-04 18:40 ` Eli Zaretskii
2018-07-07 11:57 ` Eli Zaretskii [this message]
2018-07-07 18:22 ` Paul Eggert
2018-07-07 18:40 ` Eli Zaretskii
2018-07-04 16:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831scfjm1d.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.