From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31782: 26.1; dired-recursive-deletes broken Date: Tue, 31 Jul 2018 19:00:44 +0300 Message-ID: <831sbjpf83.fsf@gnu.org> References: <834li9qlu3.fsf@gnu.org> <87po0vy8ja.fsf@gmail.com> <83in6n4drr.fsf@gnu.org> <87efh9wmaf.fsf@gmail.com> <87wov0uwai.fsf@gmail.com> <87va8w18vz.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1533052950 3579 195.159.176.226 (31 Jul 2018 16:02:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 31 Jul 2018 16:02:30 +0000 (UTC) Cc: 31782@debbugs.gnu.org, sdl.web@gmail.com, juri@linkov.net To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 31 18:02:26 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkX6P-0000o9-QC for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Jul 2018 18:02:25 +0200 Original-Received: from localhost ([::1]:59661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkX8W-0002Ws-EA for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Jul 2018 12:04:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkX57-0000BS-Dg for bug-gnu-emacs@gnu.org; Tue, 31 Jul 2018 12:01:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkX54-0008BP-AC for bug-gnu-emacs@gnu.org; Tue, 31 Jul 2018 12:01:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59789) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fkX54-0008BB-6P for bug-gnu-emacs@gnu.org; Tue, 31 Jul 2018 12:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fkX53-0003Kk-S4 for bug-gnu-emacs@gnu.org; Tue, 31 Jul 2018 12:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Jul 2018 16:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31782 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31782-submit@debbugs.gnu.org id=B31782.153305285212789 (code B ref 31782); Tue, 31 Jul 2018 16:01:01 +0000 Original-Received: (at 31782) by debbugs.gnu.org; 31 Jul 2018 16:00:52 +0000 Original-Received: from localhost ([127.0.0.1]:36574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkX4t-0003KD-MP for submit@debbugs.gnu.org; Tue, 31 Jul 2018 12:00:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkX4r-0003K0-JS for 31782@debbugs.gnu.org; Tue, 31 Jul 2018 12:00:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkX4l-00086z-Ds for 31782@debbugs.gnu.org; Tue, 31 Jul 2018 12:00:44 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkX4e-00085W-8q; Tue, 31 Jul 2018 12:00:36 -0400 Original-Received: from [176.228.60.248] (port=4512 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fkX4d-0007CJ-Lf; Tue, 31 Jul 2018 12:00:36 -0400 In-reply-to: <87va8w18vz.fsf@gmail.com> (message from Noam Postavsky on Mon, 30 Jul 2018 21:39:12 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149112 Archived-At: > From: Noam Postavsky > Date: Mon, 30 Jul 2018 21:39:12 -0400 > Cc: 31782@debbugs.gnu.org, Juri Linkov > > There are differences in both the interface and implementation which > make it difficult to merge these, even though the functionality has some > overlap. Maybe something could be done later, but for now we'll have to > settle for taking it as is (modulo the fix for the standard value > problem). Here is the backported patch: LGTM, thanks. > +;; For backward compatibility check if short y/n answers are preferred. > +(defcustom read-answer-short 'auto > + "Control whether `read-answer' accepts short answers. This is unnecessarily vague. How about If non-nil, `read-answer' accepts single-character answers. with all the rest intact? > I guess assoc-delete-all should be announced in NEWS too? Yes, please. > Although it looks like it could be replaced with cl-delete instead. Such a small and simple function doesn't justify loading cl-seq, IMO. And we already have a similar function in subr.el. > -(defcustom read-answer-short (eq (symbol-function 'yes-or-no-p) 'y-or-n-p) > - "If non-nil, accept short answers to the question." > - :type 'boolean > +(defcustom read-answer-short 'auto > + "Control whether `read-answer' accepts short answers. > +If t, accept short (single key-press) answers to the question. > +If nil, require long answers. If `auto', accept short answers if > +the function cell of `yes-or-no-p' is set to `y-or-on-p'." > + :type '(choice (const :tag "Accept short answers" t) > + (const :tag "Require long answer" nil) > + (const :tag "Guess preference" auto)) > :version "27.1" The :version tag should change, right? > And once backported, we should remove the announcement from 27.1 NEWS, > since the new function it will already be introduced in 26.2: Right. Thanks.