From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Bignum speedup patch causes crash at startup Date: Tue, 04 Sep 2018 19:24:21 +0300 Message-ID: <831sa9z0wa.fsf@gnu.org> References: <838t4hz4bd.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1536078187 19438 195.159.176.226 (4 Sep 2018 16:23:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2018 16:23:07 +0000 (UTC) Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org To: eggert@cs.ucla.edu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 04 18:23:03 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxE6Y-0004rS-CP for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 18:23:02 +0200 Original-Received: from localhost ([::1]:51699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxE8e-0001Tn-Na for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 12:25:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxE81-0001TV-59 for emacs-devel@gnu.org; Tue, 04 Sep 2018 12:24:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxE7w-0004qz-4k for emacs-devel@gnu.org; Tue, 04 Sep 2018 12:24:33 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxE7v-0004qv-VH; Tue, 04 Sep 2018 12:24:28 -0400 Original-Received: from [176.228.60.248] (port=3305 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fxE7v-0001cw-JZ; Tue, 04 Sep 2018 12:24:27 -0400 In-reply-to: <838t4hz4bd.fsf@gnu.org> (message from Eli Zaretskii on Tue, 04 Sep 2018 18:10:30 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229235 Archived-At: > Date: Tue, 04 Sep 2018 18:10:30 +0300 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > Paul, why do we need to call init_bignum_once at dump time? And btw, why on earth this call: 0x01231e45 in Fround (arg=make_number(9), divisor=make_number(1)) would need to use GMP?? It's due to this code: if (!FLOATP (arg) && !FLOATP (divisor)) { if (EQ (divisor, make_fixnum (0))) xsignal0 (Qarith_error); int_divide (mpz[0], *bignum_integer (&mpz[0], arg), *bignum_integer (&mpz[1], divisor)); return make_integer_mpz (); } I don't understand why it prefers GMP calls to a simple double division, when both arguments are fixnums. What am I missing?