From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32795: bug#32832: [PATCH] Fix 'provided-mode-derived-p' when the parent is an alias Date: Sat, 29 Sep 2018 10:01:01 +0300 Message-ID: <831s9c7poy.fsf@gnu.org> References: <20180925040939.66376-1-andrew@schwartzmeyer.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1538204407 16422 195.159.176.226 (29 Sep 2018 07:00:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 29 Sep 2018 07:00:07 +0000 (UTC) Cc: 32795-done@debbugs.gnu.org To: andrew@schwartzmeyer.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 29 09:00:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g69EQ-0004Aa-T1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Sep 2018 09:00:03 +0200 Original-Received: from localhost ([::1]:49743 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g69GX-0003rT-FZ for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Sep 2018 03:02:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g69GR-0003rB-K2 for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2018 03:02:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g69GM-0000Bv-Jr for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2018 03:02:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g69GM-0000Bo-F0 for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2018 03:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g69GM-0003vX-Cb for bug-gnu-emacs@gnu.org; Sat, 29 Sep 2018 03:02:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Sep 2018 07:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 32795 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 32795@debbugs.gnu.org, eliz@gnu.org, andrew@schwartzmeyer.com Original-Received: via spool by 32795-done@debbugs.gnu.org id=D32795.153820449115050 (code D ref 32795); Sat, 29 Sep 2018 07:02:02 +0000 Original-Received: (at 32795-done) by debbugs.gnu.org; 29 Sep 2018 07:01:31 +0000 Original-Received: from localhost ([127.0.0.1]:58231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g69Fr-0003uf-AB for submit@debbugs.gnu.org; Sat, 29 Sep 2018 03:01:31 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g69Fo-0003uS-Et for 32795-done@debbugs.gnu.org; Sat, 29 Sep 2018 03:01:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g69Fa-0008Ki-Px for 32795-done@debbugs.gnu.org; Sat, 29 Sep 2018 03:01:21 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g69Fa-0008Ke-KK; Sat, 29 Sep 2018 03:01:14 -0400 Original-Received: from [176.228.60.248] (port=4063 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g69FZ-0004K0-Hk; Sat, 29 Sep 2018 03:01:14 -0400 In-reply-to: <20180925040939.66376-1-andrew@schwartzmeyer.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150747 Archived-At: > From: andrew@schwartzmeyer.com > Date: Mon, 24 Sep 2018 21:09:39 -0700 > > From: Andrew Schwartzmeyer > > Authors of Emacs packages often derive from an alias of a mode instead > of the mode directly. This is especially the case when deriving from > 'prog-mode' as it is relatively new. Unfortunately, using > 'derived-mode-p' to check if some mode is derived from an alias of > 'prog-mode' does not work as expected. The bug is that > 'provided-mode-derived-p' should not only return non-nil when MODE is > one of MODES, but also when MODE is an alias of one of MODES. > * lisp/subr.el (provided-mode-derived-p): > Return non-nil when MODE is an alias of any of MODES (Bug#32795). > * test/lisp/subr-tests.el: Add tests for the above. Thanks, pushed. In the future please either format your patches with "git format-patch" or make sure the first line of the commit log message is a single sentence followed by an empty line (this is explained in CONTRIBUTE), to make the patch application easier. Also, you don't seem to have a copyright assignment on file, and this contribution comes close to exhausting the amount of changes we can accept without such an assignment. So I urge you to start your legal paperwork rolling, to allow us to accept more contributions from you. If you are interested, I will send you the assignment form off-list.