From: Eli Zaretskii <eliz@gnu.org>
To: andrew@schwartzmeyer.com
Cc: 32795-done@debbugs.gnu.org
Subject: bug#32795: bug#32832: [PATCH] Fix 'provided-mode-derived-p' when the parent is an alias
Date: Sat, 29 Sep 2018 10:01:01 +0300 [thread overview]
Message-ID: <831s9c7poy.fsf@gnu.org> (raw)
In-Reply-To: <20180925040939.66376-1-andrew@schwartzmeyer.com>
> From: andrew@schwartzmeyer.com
> Date: Mon, 24 Sep 2018 21:09:39 -0700
>
> From: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
>
> Authors of Emacs packages often derive from an alias of a mode instead
> of the mode directly. This is especially the case when deriving from
> 'prog-mode' as it is relatively new. Unfortunately, using
> 'derived-mode-p' to check if some mode is derived from an alias of
> 'prog-mode' does not work as expected. The bug is that
> 'provided-mode-derived-p' should not only return non-nil when MODE is
> one of MODES, but also when MODE is an alias of one of MODES.
> * lisp/subr.el (provided-mode-derived-p):
> Return non-nil when MODE is an alias of any of MODES (Bug#32795).
> * test/lisp/subr-tests.el: Add tests for the above.
Thanks, pushed.
In the future please either format your patches with "git
format-patch" or make sure the first line of the commit log message is
a single sentence followed by an empty line (this is explained in
CONTRIBUTE), to make the patch application easier.
Also, you don't seem to have a copyright assignment on file, and this
contribution comes close to exhausting the amount of changes we can
accept without such an assignment. So I urge you to start your legal
paperwork rolling, to allow us to accept more contributions from you.
If you are interested, I will send you the assignment form off-list.
prev parent reply other threads:[~2018-09-29 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 4:09 bug#32832: [PATCH] Fix 'provided-mode-derived-p' when the parent is an alias andrew
2018-09-26 5:10 ` bug#32832: Please close this bug Andrew Schwartzmeyer
2018-09-26 12:18 ` Noam Postavsky
2018-09-29 7:01 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831s9c7poy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32795-done@debbugs.gnu.org \
--cc=andrew@schwartzmeyer.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.