From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33476: [PATCH] Fix occur revert with list-matching-lines-jump-to-current-line Date: Sat, 08 Dec 2018 11:25:14 +0200 Message-ID: <831s6s5q11.fsf@gnu.org> References: <874lc7sdok.fsf@konghq.com> <87efbagn6n.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1544261047 3118 195.159.176.226 (8 Dec 2018 09:24:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Dec 2018 09:24:07 +0000 (UTC) Cc: 33476@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 08 10:24:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVYqA-0000hW-SX for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Dec 2018 10:24:02 +0100 Original-Received: from localhost ([::1]:50081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVYsH-00084p-I3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Dec 2018 04:26:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVYsB-00084j-OF for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 04:26:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVYs6-0001ji-DP for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 04:26:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33373) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gVYs5-0001jJ-Q5 for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 04:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gVYs5-00061q-J8 for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2018 04:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Dec 2018 09:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33476 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33476-submit@debbugs.gnu.org id=B33476.154426114923154 (code B ref 33476); Sat, 08 Dec 2018 09:26:01 +0000 Original-Received: (at 33476) by debbugs.gnu.org; 8 Dec 2018 09:25:49 +0000 Original-Received: from localhost ([127.0.0.1]:37631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVYrs-00061N-Up for submit@debbugs.gnu.org; Sat, 08 Dec 2018 04:25:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVYrr-00061C-Kk for 33476@debbugs.gnu.org; Sat, 08 Dec 2018 04:25:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVYrg-0001Yj-9K for 33476@debbugs.gnu.org; Sat, 08 Dec 2018 04:25:42 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVYre-0001Xr-LR; Sat, 08 Dec 2018 04:25:34 -0500 Original-Received: from [176.228.60.248] (port=4537 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gVYrc-0001BG-FV; Sat, 08 Dec 2018 04:25:34 -0500 In-reply-to: <87efbagn6n.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 24 Nov 2018 23:54:24 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153209 Archived-At: > From: Juri Linkov > Date: Sat, 24 Nov 2018 23:54:24 +0200 > > > I reproduced this bug with Emacs 26.1 and 26.1.90 using -Q option. > > > > When pressing 'g' (revert-buffer) in an *Occur* buffer, in the case of > > having `list-matching-lines-jump-to-current-line' set to non-nil, the > > function errors as it can't find orig-line. > > > > I'm attaching a patch that adds a guard to the list of guards before > > inserting the current line. > > Eli, is it ok to install this submitted patch to the release branch emacs-26? > At least, it prevents the error signal. > > I see that for Emacs 27 in master this feature is completely rewritten. It was rewritten to fix the same bug, AFAIU, see bug#32543. Why do we need to solve it again in emacs-26? > But still I found a bug in master that can be fixed with another patch. > The following patch is for Emacs 27: What is the bug you found in the master branch? And which patch do you propose for the emacs-26 branch? Thanks.