From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build Date: Fri, 14 Dec 2018 15:29:12 +0200 Message-ID: <831s6kgrtj.fsf@gnu.org> References: <20181214085417.15440.18845@vcs0.savannah.gnu.org> <20181214085418.6616820538@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1544794045 2425 195.159.176.226 (14 Dec 2018 13:27:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Dec 2018 13:27:25 +0000 (UTC) Cc: ari.roponen@gmail.com, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 14 14:27:21 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXnUu-0000Vy-8d for ged-emacs-devel@m.gmane.org; Fri, 14 Dec 2018 14:27:20 +0100 Original-Received: from localhost ([::1]:33524 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXnX1-00024p-1K for ged-emacs-devel@m.gmane.org; Fri, 14 Dec 2018 08:29:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXnWu-00024Y-Ka for emacs-devel@gnu.org; Fri, 14 Dec 2018 08:29:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXnWt-0007w4-L5 for emacs-devel@gnu.org; Fri, 14 Dec 2018 08:29:24 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXnWo-0007uz-0C; Fri, 14 Dec 2018 08:29:18 -0500 Original-Received: from [176.228.60.248] (port=4748 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gXnWn-0000Z5-39; Fri, 14 Dec 2018 08:29:17 -0500 In-reply-to: (message from Robert Pluim on Fri, 14 Dec 2018 13:18:41 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231831 Archived-At: > From: Robert Pluim > Date: Fri, 14 Dec 2018 13:18:41 +0100 > Cc: Ari Roponen > > Eli, what would be your preferred type of solution to avoid this in > future? If at all possible, I prefer a single definition of each struct, with as few #ifdef's as possible. If some member is not used in some configuration, I prefer to have it anyway, unless it cannot be compiled in the configuration(s) that don't use it (e.g., because it uses a data type that is only visible in some configurations). > At the very least I propose syncing the comments: Yes, please push.