From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691) Date: Sat, 22 Dec 2018 11:07:37 +0200 Message-ID: <831s6aaq06.fsf@gnu.org> References: <8336qwdixp.fsf@gnu.org> <20181217204746.53492-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1545469630 26610 195.159.176.226 (22 Dec 2018 09:07:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Dec 2018 09:07:10 +0000 (UTC) Cc: phst@google.com, 28691@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 22 10:07:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gadFS-0006oQ-1A for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 10:07:06 +0100 Original-Received: from localhost ([::1]:59900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadHY-0006rq-Dz for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 04:09:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadHN-0006rj-Jv for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 04:09:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gadHK-00024I-Dt for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 04:09:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54870) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gadHK-00024E-Ar for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 04:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gadHK-0003OL-5H for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 04:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2018 09:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28691 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28691-submit@debbugs.gnu.org id=B28691.154546968312962 (code B ref 28691); Sat, 22 Dec 2018 09:09:02 +0000 Original-Received: (at 28691) by debbugs.gnu.org; 22 Dec 2018 09:08:03 +0000 Original-Received: from localhost ([127.0.0.1]:59127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gadGN-0003N0-77 for submit@debbugs.gnu.org; Sat, 22 Dec 2018 04:08:03 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gadGM-0003MW-BH for 28691@debbugs.gnu.org; Sat, 22 Dec 2018 04:08:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gadGG-0001MM-GB for 28691@debbugs.gnu.org; Sat, 22 Dec 2018 04:07:57 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadGC-0001JX-I8; Sat, 22 Dec 2018 04:07:52 -0500 Original-Received: from [176.228.60.248] (port=2557 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gadGC-0005wv-5z; Sat, 22 Dec 2018 04:07:52 -0500 In-reply-to: <20181217204746.53492-1-phst@google.com> (message from Philipp Stephani on Mon, 17 Dec 2018 21:47:46 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153719 Archived-At: > From: Philipp Stephani > Cc: 28691@debbugs.gnu.org, > Philipp Stephani > Date: Mon, 17 Dec 2018 21:47:46 +0100 > > * src/process.c (Fmake_process): Add new keyword argument > ':file-handler'. > (syms_of_process) : Define new symbols. > > * lisp/files.el (file-name-non-special): Add support for > 'make-process'. > > * test/src/process-tests.el (make-process/file-handler/found) > (make-process/file-handler/not-found) > (make-process/file-handler/disable): New unit tests. > (process-tests--file-handler): New helper function. > > * test/lisp/files-tests.el > (files-tests-file-name-non-special-make-process): New unit test. > > * doc/lispref/files.texi (Magic File Names): Document that > 'make-process' can invoke file name handlers. > > * doc/lispref/processes.texi (Asynchronous Processes): Document > ':file-handlers' argument to 'make-process'. Thanks, this LGTM, but some of the tests use the Emacs binary, while others still use /bin/true for some reason. What am I missing? Please also include etc/NEWS change in the log message.