From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: open-{gnutls,network}-stream backwards compatibility Date: Wed, 02 Jan 2019 19:04:27 +0200 Message-ID: <831s5v3s9w.fsf@gnu.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1546448600 21759 195.159.176.226 (2 Jan 2019 17:03:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 Jan 2019 17:03:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 02 18:03:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gejvH-0005YG-Hb for ged-emacs-devel@m.gmane.org; Wed, 02 Jan 2019 18:03:15 +0100 Original-Received: from localhost ([127.0.0.1]:46374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gejxO-000162-BK for ged-emacs-devel@m.gmane.org; Wed, 02 Jan 2019 12:05:26 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gejwl-00015j-3C for emacs-devel@gnu.org; Wed, 02 Jan 2019 12:04:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gejwf-00085y-56 for emacs-devel@gnu.org; Wed, 02 Jan 2019 12:04:46 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gejwa-00084G-BZ; Wed, 02 Jan 2019 12:04:37 -0500 Original-Received: from [176.228.60.248] (port=2521 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gejwY-0002CX-Az; Wed, 02 Jan 2019 12:04:36 -0500 In-reply-to: (message from Robert Pluim on Wed, 02 Jan 2019 17:49:13 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232093 Archived-At: > From: Robert Pluim > Date: Wed, 02 Jan 2019 17:49:13 +0100 > > 1. As part of that fix, Iʼd like to change the signature of > open-gnutls-stream from > > (open-gnutls-stream name buffer host service &optional nowait) > > to > > (open-gnutls-stream name buffer host service &optional nowait parameters) > > Normally this would be fine, I think, except that the caller in > Emacs core derives the value of 'nowait' from the plist that would be > passed in via 'parameters' anyway, so Iʼm tempted to just change it > to: > > (open-gnutls-stream name buffer host service &optional parameters) > > then adjust the single in-core caller and have open-gnutls-stream > call plist-get. > > Does anyone see any issue with doing this? How about changing the code so that PARAMETERS could also be a symbol, in which case it would be interpreted in backward-compatible way? > Again Iʼm tempted to change open-network-stream such that not > specifying :client-certificate is the same as specifying t, so > that all Emacs core and external packages can take advantage of > the feature just by adjusting their .authinfo entries, similarly > to how password lookup automatically works today. However, this > would be a change in default behaviour, plus I know some people > are very sensitive to changes in this particular area, so I > thought Iʼd ask here before doing anything. IMO, we should resist the temptation of making backward-incompatible changes. From bitter experience, even obscure internal functions are sometimes used, and their users don't expect us to break the APIs.