From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 34763@debbugs.gnu.org
Subject: bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function
Date: Tue, 12 Mar 2019 19:18:55 +0200 [thread overview]
Message-ID: <831s3c3ta8.fsf@gnu.org> (raw)
In-Reply-To: <787f765a-42f4-40d0-3b78-e751f546fe6c@yandex.ru> (message from Dmitry Gutov on Tue, 12 Mar 2019 11:08:06 +0200)
> Cc: 34763@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Tue, 12 Mar 2019 11:08:06 +0200
>
> On 11.03.2019 16:30, Eli Zaretskii wrote:
>
> > Does it help to replace this:
> >
> > (defsubst url-http-debug (&rest args)
> > (if quit-flag
> >
> > with this:
> >
> > (defsubst url-http-debug (&rest args)
> > (if (eq quit-flag t)
> >
> > in url-http.el?
>
> No change, unfortunately. I double-checked.
Crystal ball says there _was_ in fact a change: the error message text
has changed slightly. Which means there's one more place with a
similar problem.
The below should fix both; please see if it does, and also whether it
fixes your original real-life use case.
Thanks.
diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index 76faac1..651a2cc 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -150,7 +150,7 @@ url-https-default-port
;; These routines will allow us to implement persistent HTTP
;; connections.
(defsubst url-http-debug (&rest args)
- (if quit-flag
+ (if (eq quit-flag t)
(let ((proc (get-buffer-process (current-buffer))))
;; The user hit C-g, honor it! Some things can get in an
;; incredibly tight loop (chunked encoding)
diff --git a/lisp/url/url-util.el b/lisp/url/url-util.el
index cb80ec6..72ff4f1 100644
--- a/lisp/url/url-util.el
+++ b/lisp/url/url-util.el
@@ -61,7 +61,7 @@ url-debug
;;;###autoload
(defun url-debug (tag &rest args)
- (if quit-flag
+ (if (eq quit-flag t)
(error "Interrupted!"))
(if (or (eq url-debug t)
(numberp url-debug)
next prev parent reply other threads:[~2019-03-12 17:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 21:34 bug#34763: 27.0.50; url-retrieve-synchronously misbehaves inside eldoc-documentation-function Dmitry Gutov
2019-03-11 0:18 ` Dmitry Gutov
2019-03-11 14:30 ` Eli Zaretskii
2019-03-12 9:08 ` Dmitry Gutov
2019-03-12 15:02 ` Dmitry Gutov
2019-03-12 17:18 ` Eli Zaretskii [this message]
2019-03-12 17:44 ` Dmitry Gutov
2019-03-12 18:00 ` Eli Zaretskii
2019-03-12 20:05 ` Dmitry Gutov
2019-03-13 16:49 ` Eli Zaretskii
2019-03-15 14:24 ` Dmitry Gutov
2019-03-15 15:47 ` Eli Zaretskii
2019-03-15 16:07 ` Dmitry Gutov
2019-03-15 14:29 ` Dmitry Gutov
2019-03-15 15:49 ` Eli Zaretskii
2019-04-03 23:37 ` Dmitry Gutov
2019-04-04 13:04 ` Eli Zaretskii
2019-04-04 13:29 ` Dmitry Gutov
2019-04-04 14:36 ` Eli Zaretskii
2019-04-05 0:29 ` Dmitry Gutov
2019-04-05 6:14 ` Eli Zaretskii
2019-04-08 10:25 ` Dmitry Gutov
2019-04-08 15:20 ` Eli Zaretskii
2019-04-08 16:42 ` Dmitry Gutov
2019-04-08 17:13 ` Eli Zaretskii
2019-04-09 0:48 ` Dmitry Gutov
2019-04-09 6:34 ` Eli Zaretskii
2019-04-10 1:44 ` Dmitry Gutov
2019-04-10 15:46 ` Eli Zaretskii
2019-04-11 1:03 ` Dmitry Gutov
2019-04-11 7:59 ` Andreas Schwab
2019-04-11 13:08 ` Dmitry Gutov
2019-04-11 15:08 ` Dmitry Gutov
2019-04-11 16:22 ` Eli Zaretskii
2019-04-11 16:31 ` Dmitry Gutov
2019-04-13 0:44 ` Dmitry Gutov
2019-05-15 5:16 ` Lars Ingebrigtsen
2019-05-21 1:02 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831s3c3ta8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34763@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.