From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34655: 26.1.92; Segfault in module with --module-assertions Date: Thu, 21 Mar 2019 19:00:42 +0200 Message-ID: <831s30upqd.fsf@gnu.org> References: <874l8r1t3a.fsf@tcd.ie> <8336oamu3y.fsf@gnu.org> <87h8c1cv6l.fsf@tcd.ie> <83lg1dwhse.fsf@gnu.org> <87va0h12js.fsf@tcd.ie> <835zsgw3ui.fsf@gnu.org> <87ef7486h0.fsf@tcd.ie> <83r2b4ul1c.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="257621"; mail-complaints-to="usenet@blaine.gmane.org" Cc: contovob@tcd.ie, 34655@debbugs.gnu.org To: Philipp Stephani , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 21 18:16:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h71IZ-0014sD-7s for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 18:16:11 +0100 Original-Received: from localhost ([127.0.0.1]:42579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h71IY-0006ma-0C for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Mar 2019 13:16:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h71Fg-0003UJ-8P for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 13:13:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7140-0006B3-W7 for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 13:01:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h713u-0005oy-Tb for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 13:01:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h713u-0001QA-KI for bug-gnu-emacs@gnu.org; Thu, 21 Mar 2019 13:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Mar 2019 17:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34655 X-GNU-PR-Package: emacs Original-Received: via spool by 34655-submit@debbugs.gnu.org id=B34655.15531876535440 (code B ref 34655); Thu, 21 Mar 2019 17:01:02 +0000 Original-Received: (at 34655) by debbugs.gnu.org; 21 Mar 2019 17:00:53 +0000 Original-Received: from localhost ([127.0.0.1]:53454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h713k-0001PZ-St for submit@debbugs.gnu.org; Thu, 21 Mar 2019 13:00:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h713j-0001PM-Bv for 34655@debbugs.gnu.org; Thu, 21 Mar 2019 13:00:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h713b-0004b1-PE; Thu, 21 Mar 2019 13:00:44 -0400 Original-Received: from [176.228.60.248] (port=1414 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h713b-0007d8-2A; Thu, 21 Mar 2019 13:00:43 -0400 In-reply-to: (message from Philipp Stephani on Thu, 21 Mar 2019 17:11:41 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156573 Archived-At: > From: Philipp Stephani > Date: Thu, 21 Mar 2019 17:11:41 +0100 > Cc: "Basil L. Contovounesios" , 34655@debbugs.gnu.org > > I haven't checked everything in detail, but my impression is that this > is rather another instance of bug#31238. Fixing this only when module > assertions are enabled will probably not fix anything, but rather mask > issues. Reverting commit 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a is > still the right approach here. Can you please hold off a bit? I've > almost completed the revert, but haven't pushed it yet. Once that's in > we can check whether it also fixes this issue. I will CC Stefan, who committed 3eb93c07f7a60ac9ce8a16f10c3afd5a3a31243a. I'm not sure we should revert that; we could instead add GC protection for those parts that need it. And the list consed by module-assertions certainly is one of those.