From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere) Date: Sat, 23 Mar 2019 20:16:41 +0200 Message-ID: <831s2xpiba.fsf@gnu.org> References: <87wokp4okn.fsf@gmail.com> <83ef6xpo6b.fsf@gnu.org> <0f4be9a6-6e09-f55d-9f58-2a15aef264cd@cs.ucla.edu> <837ecpplw8.fsf@gnu.org> <87imw94hi2.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="206763"; mail-complaints-to="usenet@blaine.gmane.org" Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 23 19:21:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7lGP-000rfI-Fi for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2019 19:21:01 +0100 Original-Received: from localhost ([127.0.0.1]:46409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7lGO-0000EX-Dm for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2019 14:21:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7lFZ-0000Bf-HP for emacs-devel@gnu.org; Sat, 23 Mar 2019 14:20:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7lCa-00027e-KA; Sat, 23 Mar 2019 14:17:05 -0400 Original-Received: from [176.228.60.248] (port=2672 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h7lCX-0008Nt-8U; Sat, 23 Mar 2019 14:17:04 -0400 In-reply-to: <87imw94hi2.fsf@gmail.com> (message from Alex on Sat, 23 Mar 2019 11:39:49 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234659 Archived-At: > From: Alex > Cc: Paul Eggert , emacs-devel@gnu.org > Date: Sat, 23 Mar 2019 11:39:49 -0600 > > > As a rule of thumb that is 99% true, everything in xdisp.c is generic, > > i.e. independent of the terminal-specific implementation. The > > terminal-dependent stuff is in xterm.c/xfns.c (for X), > > w32term.c/w32fns.c (for w32), nsterm.m/nsfns.m (for NS), and term.c > > (for TTY). > > Which the naming scheme should reflect, IMO. This includes the presence > of x_* procedures in the NS/W32 code that Stefan mentioned. But what you propose in the patch stops short of that goal, it just renames the functions that are explicitly called from xdisp.c. It doesn't rename x_* functions in files unrelated to X. I'm not sure this partial renaming is worth the trouble. > P.S. Should x_clear_window_mouse_face instead be renamed to > clear_window_mouse_face since it doesn't depend on HAVE_WINDOW_SYSTEM > like the others do? It does depend on the window-system, albeit somewhat subtly: it is only invoked for some terminal types.