From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35204: 27.0.50; Crash on Cygwin Date: Fri, 12 Apr 2019 18:15:40 +0300 Message-ID: <831s27mezn.fsf@gnu.org> References: <83ftqr7bnb.fsf@gnu.org> <8336mq6i49.fsf@gnu.org> <83ef6865nj.fsf@gnu.org> <83a7gv4s1b.fsf@gnu.org> <56e372ca-748c-a335-1066-a1032ae1d894@cornell.edu> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="12933"; mail-complaints-to="usenet@blaine.gmane.org" Cc: yamaoka@jpl.org, 35204@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 12 17:17:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hExvU-0003Fj-Rm for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Apr 2019 17:17:12 +0200 Original-Received: from localhost ([127.0.0.1]:38575 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hExvT-0001Di-MD for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Apr 2019 11:17:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hExvL-0001DH-08 for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 11:17:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hExvK-0004w8-5J for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 11:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hExvJ-0004vt-V1 for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 11:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hExvJ-0006VL-MX for bug-gnu-emacs@gnu.org; Fri, 12 Apr 2019 11:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Apr 2019 15:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35204 X-GNU-PR-Package: emacs Original-Received: via spool by 35204-submit@debbugs.gnu.org id=B35204.155508218124954 (code B ref 35204); Fri, 12 Apr 2019 15:17:01 +0000 Original-Received: (at 35204) by debbugs.gnu.org; 12 Apr 2019 15:16:21 +0000 Original-Received: from localhost ([127.0.0.1]:56622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hExuf-0006UQ-Fm for submit@debbugs.gnu.org; Fri, 12 Apr 2019 11:16:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hExuc-0006UB-9N for 35204@debbugs.gnu.org; Fri, 12 Apr 2019 11:16:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hExuW-00044C-HL; Fri, 12 Apr 2019 11:16:12 -0400 Original-Received: from [176.228.60.248] (port=4294 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hExuQ-0003tU-Vb; Fri, 12 Apr 2019 11:16:10 -0400 In-reply-to: <56e372ca-748c-a335-1066-a1032ae1d894@cornell.edu> (message from Ken Brown on Fri, 12 Apr 2019 14:54:21 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157556 Archived-At: > From: Ken Brown > CC: "35204@debbugs.gnu.org" <35204@debbugs.gnu.org> > Date: Fri, 12 Apr 2019 14:54:21 +0000 > > I can replicate the crash on my system, but reverting only a tiny part of the > commits in question seems to fix it, in the sense that I can successfully > evaluate x-display-monitor-attributes-list: > > diff --git a/src/xfns.c b/src/xfns.c > index 13f66f0718..3e4d037716 100644 > --- a/src/xfns.c > +++ b/src/xfns.c > @@ -5030,7 +5030,7 @@ Internal use only, use `display-monitor-attributes-list' > instead. */) > mi->mm_height = height_mm; > > #if GTK_CHECK_VERSION (3, 22, 0) > - mi->name = xstrdup (gdk_monitor_get_model (monitor)); > + mi->name = g_strdup (gdk_monitor_get_model (monitor)); > #elif GTK_CHECK_VERSION (2, 14, 0) > mi->name = gdk_screen_get_monitor_plug_name (gscreen, i); > #endif > > I don't know enough about GTK to know why this fixes it or why no one else has > reported the problem. It's hard to see why this would be specific to Cygwin. We release storage of mi->name (in free_monitors) by calling xfree, so I'm surprised g_strdup is right here, as that is documented to need g_free instead. I wonder what am I missing.