From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/3] Don't print "process finished" into the stderr buffer. Date: Mon, 22 Apr 2019 12:37:13 +0300 Message-ID: <831s1u8jp2.fsf@gnu.org> References: <20180404120218.257212-1-phst@google.com> <20180404120218.257212-2-phst@google.com> <834lkr3ygo.fsf@gnu.org> <83lgdxzvs2.fsf@gnu.org> <83imv9b0b0.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="127318"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 22 11:38:06 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIVOm-000WzV-Qd for ged-emacs-devel@m.gmane.org; Mon, 22 Apr 2019 11:38:04 +0200 Original-Received: from localhost ([127.0.0.1]:34713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIVOl-0003mt-Fi for ged-emacs-devel@m.gmane.org; Mon, 22 Apr 2019 05:38:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIVOB-0003ma-CB for emacs-devel@gnu.org; Mon, 22 Apr 2019 05:37:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIVOB-0008Et-3f; Mon, 22 Apr 2019 05:37:27 -0400 Original-Received: from [176.228.60.248] (port=1547 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hIVO6-0007Ie-Fb; Mon, 22 Apr 2019 05:37:26 -0400 In-reply-to: (message from Stefan Monnier on Sun, 21 Apr 2019 16:57:12 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235759 Archived-At: > From: Stefan Monnier > Date: Sun, 21 Apr 2019 16:57:12 -0400 > > > But Emacs does that for ages, so in Emacs this is veteran behavior of > > the default sentinel function. > > FWIW, I don't much like this behavior and since the stderr case is new > I think we don't have to inherit this part of the behavior. By "this behavior" do you mean only the "normal" case, or also the abnormal termination case, in which case we show the reason of the abnormal termination? Philipp's proposal, AFAIU, would remove the notification for stderr even in the abnormal case, so we will have to rely on the stdout sentinel to announce the reason. Are we sure no information will be lost through this assumption, i.e. are we sure both sentinels will always make the same announcements?