From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Sat, 04 May 2019 12:04:28 +0300 Message-ID: <831s1emvz7.fsf@gnu.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="218914"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 04 11:05:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMqbY-000unJ-Uu for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 11:05:13 +0200 Original-Received: from localhost ([127.0.0.1]:53655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMqbX-0004Ll-OY for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 05:05:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMqbR-0004LP-LB for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 05:05:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMqbP-0004lo-FR for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 05:05:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36815) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMqbO-0004l9-Nn for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 05:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMqbO-000151-Dq for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 05:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 09:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15569606944134 (code B ref 35418); Sat, 04 May 2019 09:05:02 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 4 May 2019 09:04:54 +0000 Original-Received: from localhost ([127.0.0.1]:50359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMqbF-00014b-QH for submit@debbugs.gnu.org; Sat, 04 May 2019 05:04:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMqbB-00014M-Pv for 35418@debbugs.gnu.org; Sat, 04 May 2019 05:04:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMqb6-0004c2-8e; Sat, 04 May 2019 05:04:44 -0400 Original-Received: from [176.228.60.248] (port=1180 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMqb5-0000vj-Lc; Sat, 04 May 2019 05:04:44 -0400 In-reply-to: <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 03 May 2019 16:47:51 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158733 Archived-At: > From: Mattias Engdegård > Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org > Date: Fri, 03 May 2019 16:47:51 +0200 > > > It is better to cite the node names in the log, unless doing that is > > completely impractical. > > Done. I found it a bit impractical in this case, but did so anyway. Thanks, but why did you start the description of the change on a new line? Here: > * doc/emacs/files.texi > (Files): Adjust menu. > (Reverting, Auto Revert): > Add node `Auto Revert' and move general information on that topic there > from `Reverting'. > Sort paragraphs in `Auto Revert' in a rough least-to-most specific order. > Include the old `Autorevert' text and subsections into that node when > building the on-line manual. > (Autorevert): Remove. This should be formatted like this (indented 2 spaces for clarity): * doc/emacs/files.texi (Files): Adjust menu. (Reverting, Auto Revert): Add node `Auto Revert' and move general information on that topic there from `Reverting'. Sort paragraphs in `Auto Revert' in a rough least-to-most specific order. Include the old `Autorevert' text and subsections into that node when building the on-line manual. (Autorevert): Remove. IOW, only when you describe changes to another node you should start on a new line. The above is the formatting produced by "C-x 4 a" and its ilk. > > > -@node Autorevert > > > -@section Auto Reverting Non-File Buffers > > > +@c The including file must provide its own @node and @section > > > lines. > > > > So maybe we shouldn't remove the @node here? How about making it a > > subsection of "Auto Revert" instead? > > The text in arevert-xtra has two subsections already. Then we would > have three subsections, where the first acts as a sort of prelude to > the two others. That might work for the on-line manual, but how would > it fit into emacs-xtra? What would the section be then? No, I meant make "Autorevert" (under its new name) a subsection of "Auto Revert", and the 2 subsections of "Autorevert" sub-subsections. Or did I misunderstand the problem you were describing? > > > periodically even when file notifications are used. Such polling > > > is > > > usually unnecessary, and turning it off may save power by relying > > > on > > ^^^^^^^^^^^^^^^^^^^ > > I would say "unnecessary in many cases". "usually" begs the question > > why by default we do poll. Bonus points for adding some hint about > > what rare situations do need such polling, as I think this > > description > > sounds like a small riddle without that, and doesn't allow people to > > make an educated decision regarding whether they do or don't want the > > polling turned off. > > Done, but the hint you are asking for does come right after: > > [...] However, > notification is ineffective on certain file systems; mainly network > file system on Unix-like machines, where files can be altered from > other machines. Yes, but that hint doesn't mention the polling. I think it's important to tell that polling is needed in these rare cases. Thanks.