From: Eli Zaretskii <eliz@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: Emacs master build failing on RHEL 6.8
Date: Tue, 07 May 2019 18:13:35 +0300 [thread overview]
Message-ID: <831s1ajo0w.fsf@gnu.org> (raw)
In-Reply-To: <CAFyQvY2i5HFFdrAZ_3CV4u-oOxUXpOYF0AXG2wxW1VuP2P0ORg@mail.gmail.com> (message from Kaushal Modi on Tue, 7 May 2019 10:41:55 -0400)
> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Tue, 7 May 2019 10:41:55 -0400
> Cc: Paul Eggert <eggert@cs.ucla.edu>, Emacs developers <emacs-devel@gnu.org>
>
> 4:#define LIBRSVG_MAJOR_VERSION (2)
> 5:#define LIBRSVG_MINOR_VERSION (26)
> 6:#define LIBRSVG_MICRO_VERSION (0)
> 7:#define LIBRSVG_VERSION ""
> 9:#define LIBRSVG_CHECK_VERSION(major,minor,micro) \
> 10: (LIBRSVG_MAJOR_VERSION > (major) || \
> 11: (LIBRSVG_MAJOR_VERSION == (major) && LIBRSVG_MINOR_VERSION > (minor))
> || \
> 12: (LIBRSVG_MAJOR_VERSION == (major) && LIBRSVG_MINOR_VERSION == (minor)
> && LIBRSVG_MICRO_VERSION >= (micro)))
>
> The version is 2.26.0.
Maybe I'm blind, but I don't see anything wrong here (although
LIBRSVG_VERSION's value looks strange).
Does it help to flush the # characters all the way to the left, and
also to take the conditions in parens? Like this:
#if GNUC_PREREQ (4, 6, 0)
#pragma GCC diagnostic push
#endif
#if (LIBRSVG_CHECK_VERSION (2, 45, 1)) && (GNUC_PREREQ (4, 2, 0))
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
> I see " #define LIBRSVG_CHECK_VERSION(major,minor,micro) \" .. note that
> there is no space before the opening bracket .. is that detail important?
Yes, and the lack of space in the macro definition is correct.
next prev parent reply other threads:[~2019-05-07 15:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 12:00 Emacs master build failing on RHEL 6.8 Kaushal Modi
2019-05-07 14:34 ` Eli Zaretskii
2019-05-07 14:41 ` Kaushal Modi
2019-05-07 15:13 ` Eli Zaretskii [this message]
2019-05-07 15:30 ` Stefan Monnier
2019-05-07 15:52 ` Eli Zaretskii
2019-05-07 16:01 ` Kaushal Modi
2019-05-07 18:22 ` Eli Zaretskii
2019-05-07 19:46 ` Kaushal Modi
2019-05-08 5:47 ` Eli Zaretskii
2019-05-08 8:03 ` Andreas Schwab
2019-05-08 11:42 ` Kaushal Modi
2019-05-08 12:27 ` Eli Zaretskii
2019-05-08 12:49 ` Kaushal Modi
2019-05-08 13:05 ` Eli Zaretskii
2019-05-08 15:07 ` Kaushal Modi
2019-05-08 15:41 ` Paul Eggert
2019-05-08 15:50 ` Kaushal Modi
2020-02-14 19:49 ` WilliamKF
2020-02-14 20:44 ` Paul Eggert
2019-05-07 18:49 ` Mattias Engdegård
2019-05-08 15:57 ` Paul Eggert
2019-05-08 17:16 ` CPP indentation bikeshed (was: Emacs master build failing on RHEL 6.8) Stefan Monnier
2019-05-09 4:25 ` Paul Eggert
2019-05-07 17:37 ` Emacs master build failing on RHEL 6.8 martin rudalics
2019-05-07 18:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831s1ajo0w.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.