From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Wed, 08 May 2019 15:35:14 +0300 Message-ID: <831s19i0ot.fsf@gnu.org> References: <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> <834l6gu6ee.fsf@gnu.org> <834l6eqdam.fsf@gnu.org> <8bbbdc62bee1dc16b6fd684e7da5ffac43f1e232.camel@acm.org> <87woj9nj77.fsf@gmx.de> <83r29fmz3f.fsf@gnu.org> <6b722334f6eaddcbbf3def636b5181c9439a172c.camel@acm.org> <831s1emvz7.fsf@gnu.org> <26e8159ac86da37d9cf555f6cb3f2dcb63ac0a67.camel@acm.org> <87y33mgo0c.fsf@gmx.de> <05128E42-E970-4C41-9DF9-E9E0BC1C9E4A@acm.org> <87tveagg4f.fsf@gmx.de> <87pnoygdx6.fsf@gmx.de> <8FEB518A-F5AA-488B-BDC5-7947FFE51394@acm.org> <87lfzlgvka.fsf@gmx.de> <3D200C55-AD11-4214-9C50-C2183F6598CC@acm.org> <78A0704A-59E6-4D25-8FF3-8FD011942885@acm.org> <837eb1ib84.fsf@gnu.org> <855D9426-4B27-4CB8-8E85-B9100B868207@acm.org> <835zqli55l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="81029"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 08 14:36:27 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOLoA-000KuP-G3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2019 14:36:26 +0200 Original-Received: from localhost ([127.0.0.1]:36400 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOLo9-0003gY-J0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2019 08:36:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOLnp-0003aM-BV for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 08:36:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOLno-0003M7-9S for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 08:36:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47018) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOLno-0003Ly-68 for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 08:36:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOLnm-0000qV-24 for bug-gnu-emacs@gnu.org; Wed, 08 May 2019 08:36:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2019 12:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.15573189403218 (code B ref 35418); Wed, 08 May 2019 12:36:01 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 8 May 2019 12:35:40 +0000 Original-Received: from localhost ([127.0.0.1]:60561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOLnQ-0000pq-AF for submit@debbugs.gnu.org; Wed, 08 May 2019 08:35:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOLnO-0000pe-Rh for 35418@debbugs.gnu.org; Wed, 08 May 2019 08:35:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOLnJ-00036g-Hv; Wed, 08 May 2019 08:35:33 -0400 Original-Received: from [176.228.60.248] (port=3045 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOLnH-0005tp-Oo; Wed, 08 May 2019 08:35:32 -0400 In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Wed, 8 May 2019 13:48:51 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158939 Archived-At: > From: Mattias Engdegård > Date: Wed, 8 May 2019 13:48:51 +0200 > Cc: Michael Albinus , 35418@debbugs.gnu.org > > the patch is a strict improvement on the code in master. I have no doubt it is. > An example of a generalisation: We could add a buffer-specific variable that tells autorevert that yes, this buffer can rely on directory notifications despite not having a buffer-file-name. All modes to which this applies would need to set that variable. > > I don't think there is a passive condition, and furthermore, because of the nature of directory notifications, any mode that qualifies is likely to be some kind of variation on Dired: a buffer whose contents is determined by the set of files in its default-directory, but not their data. OK, so how about adding such a variable as part of this improvement? Or maybe it's better to have a special property on the mode's symbol?