From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Remove display member of glyph_string
Date: Thu, 09 May 2019 20:59:08 +0300
Message-ID: <831s17h5lf.fsf@gnu.org>
References: <87a7fwe12f.fsf@gmail.com> <83ef58goru.fsf@gnu.org>
	<871s17ehmq.fsf@gmail.com> <834l63h87x.fsf@gnu.org>
	<87sgtnczvt.fsf@gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="228816"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Alex Gramiak <agrambot@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 09 19:59:51 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hOnKg-000xP5-PB
	for ged-emacs-devel@m.gmane.org; Thu, 09 May 2019 19:59:50 +0200
Original-Received: from localhost ([127.0.0.1]:58886 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hOnKf-00005D-Pv
	for ged-emacs-devel@m.gmane.org; Thu, 09 May 2019 13:59:49 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:36511)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hOnKW-0008Tt-QE
	for emacs-devel@gnu.org; Thu, 09 May 2019 13:59:41 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46607)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hOnKW-0001Iu-NO; Thu, 09 May 2019 13:59:40 -0400
Original-Received: from [176.228.60.248] (port=1284 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hOnKR-0001H9-T2; Thu, 09 May 2019 13:59:40 -0400
In-reply-to: <87sgtnczvt.fsf@gmail.com> (message from Alex Gramiak on Thu, 09
	May 2019 11:16:06 -0600)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:236343
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/236343>

> From: Alex Gramiak <agrambot@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 09 May 2019 11:16:06 -0600
> 
> > There's one more instance of FRAME_X_DISPLAY in xdisp.c which was
> > left, and it will fail compilation on non-X platforms.
> >
> > Otherwise, this LGTM, thanks.
> 
> I only see one such instance, and it's surrounded by:
> 
>  #if false && defined HAVE_X_WINDOWS
> 
> So it should be good, no?

That one, yes.  But there's one more, and it isn't conditioned by
HAVE_X_WINDOWS.  Are you maybe looking on a wrong branch?  I'm on
master.