From: Eli Zaretskii <eliz@gnu.org>
To: Alex Gramiak <agrambot@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Remove display member of glyph_string
Date: Thu, 09 May 2019 20:59:08 +0300 [thread overview]
Message-ID: <831s17h5lf.fsf@gnu.org> (raw)
In-Reply-To: <87sgtnczvt.fsf@gmail.com> (message from Alex Gramiak on Thu, 09 May 2019 11:16:06 -0600)
> From: Alex Gramiak <agrambot@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 09 May 2019 11:16:06 -0600
>
> > There's one more instance of FRAME_X_DISPLAY in xdisp.c which was
> > left, and it will fail compilation on non-X platforms.
> >
> > Otherwise, this LGTM, thanks.
>
> I only see one such instance, and it's surrounded by:
>
> #if false && defined HAVE_X_WINDOWS
>
> So it should be good, no?
That one, yes. But there's one more, and it isn't conditioned by
HAVE_X_WINDOWS. Are you maybe looking on a wrong branch? I'm on
master.
next prev parent reply other threads:[~2019-05-09 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 3:52 [PATCH] Remove display member of glyph_string Alex Gramiak
2019-05-09 5:50 ` Eli Zaretskii
2019-05-09 16:07 ` Alex Gramiak
2019-05-09 17:02 ` Eli Zaretskii
2019-05-09 17:16 ` Alex Gramiak
2019-05-09 17:59 ` Eli Zaretskii [this message]
2019-05-09 18:21 ` Alex Gramiak
2019-05-10 5:30 ` Eli Zaretskii
2019-05-11 4:20 ` Alex Gramiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831s17h5lf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=agrambot@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.