From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling. Date: Tue, 25 Jun 2019 05:41:46 +0300 Message-ID: <831rzimln9.fsf@gnu.org> References: <86lglj6bkl.fsf@gavenkoa.example.com> <87zhm6silp.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="222253"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 28434@debbugs.gnu.org, npostavs@gmail.com, gavenkoa@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 04:42:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfbPW-000vhL-0L for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 04:42:18 +0200 Original-Received: from localhost ([::1]:55988 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfbPV-00048H-2h for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 22:42:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57347) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfbPG-000489-V5 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 22:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfbPG-0007qq-2A for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 22:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44916) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfbPF-0007qI-U4 for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 22:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfbPF-00074d-Pt for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 22:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 02:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28434 X-GNU-PR-Package: emacs Original-Received: via spool by 28434-submit@debbugs.gnu.org id=B28434.156143051727178 (code B ref 28434); Tue, 25 Jun 2019 02:42:01 +0000 Original-Received: (at 28434) by debbugs.gnu.org; 25 Jun 2019 02:41:57 +0000 Original-Received: from localhost ([127.0.0.1]:58460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfbPB-00074I-3n for submit@debbugs.gnu.org; Mon, 24 Jun 2019 22:41:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfbP8-000745-8e for 28434@debbugs.gnu.org; Mon, 24 Jun 2019 22:41:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hfbP2-0007hz-VB; Mon, 24 Jun 2019 22:41:49 -0400 Original-Received: from [176.228.60.248] (port=4465 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hfbP2-0003F9-Aw; Mon, 24 Jun 2019 22:41:48 -0400 In-reply-to: (message from Lars Ingebrigtsen on Tue, 25 Jun 2019 01:09:59 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161322 Archived-At: > From: Lars Ingebrigtsen > Date: Tue, 25 Jun 2019 01:09:59 +0200 > Cc: 28434@debbugs.gnu.org, Oleksandr Gavenko > > Noam Postavsky writes: > > >> I think if you need this, you should add it to that variable, but I > >> don't think this would be a good default. > > > > Hmm, the "\ No newline at end of file" thing is a de facto standard, so > > shouldn't Emacs recognize it by default? > > Hm... is it? I've always thought that was Emacs telling me I was doing > something wrong. :-) It comes from Diff. > But if that's the case, then perhaps we should add it? Yes, I think so.