From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Sun, 13 Oct 2019 21:53:13 +0300 Message-ID: <831rvglbom.fsf@gnu.org> References: <20191012222305.jpjinkd5y2lz6xiv@Ergus> <83mue5kmfx.fsf@gnu.org> <20191013154052.yzluijtwvf2ppvks@Ergus> <83a7a4ljet.fsf@gnu.org> <20191013164424.4vyxdnm6ievyvjyf@Ergus> <837e58lgql.fsf@gnu.org> <20191013182542.34euwh2gihawyots@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="103552"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 13 20:53:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJizm-000QqK-Cs for ged-emacs-devel@m.gmane.org; Sun, 13 Oct 2019 20:53:34 +0200 Original-Received: from localhost ([::1]:41658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJizk-00055g-Si for ged-emacs-devel@m.gmane.org; Sun, 13 Oct 2019 14:53:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57456) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJiza-00055O-I5 for emacs-devel@gnu.org; Sun, 13 Oct 2019 14:53:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iJizZ-0006I0-Ag; Sun, 13 Oct 2019 14:53:21 -0400 Original-Received: from [176.228.60.248] (port=1450 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iJizY-0007ln-B3; Sun, 13 Oct 2019 14:53:20 -0400 In-reply-to: <20191013182542.34euwh2gihawyots@Ergus> (message from Ergus on Sun, 13 Oct 2019 20:25:42 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240977 Archived-At: > Date: Sun, 13 Oct 2019 20:25:42 +0200 > From: Ergus > Cc: rudalics@gmx.at, emacs-devel@gnu.org > > >Then looking at the position that causes the error will probably tell > >you what's wrong. (Is OBJECT passed to Fget_text_property a string? > >if not, position of zero is invalid.) > > > > Actually conditioning the call to face_at_pos to when IT_CHARPOS (*it) > != 0 seems to fix the issue with magit... but maybe we are just hiding > something under the carpet here. Can you imagine something more general > than that just this condition? How did it happen that IT_CHARPOS(*it) is zero? If we are iterating over a buffer, that cannot happen, because we begin from 1 and go forward. Is it->sp zero or higher? If it's higher, then we are not iterating over a buffer, but something else (a string, an image, or something similar). What are the values of it->method and it->what? Can you show the result of (gdb) pgrowx it->glyph_row