From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: :extend t inheritance Date: Sun, 27 Oct 2019 07:51:07 +0200 Message-ID: <831ruyu46s.fsf@gnu.org> References: <87zhhrmcaq.fsf@kenko.localhost.com> <83o8y6xnmn.fsf@gnu.org> <20191026014911.7riwc5oq6epjhdiq@Ergus> <8336fgvuby.fsf@gnu.org> <357181555.902089.1572117701015@mail.yahoo.com> <83ftjfthnj.fsf@gnu.org> <453335474.949467.1572131620451@mail.yahoo.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="210240"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org, ingo.lohmar@posteo.net To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 27 06:51:27 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iObSY-000sOb-Rl for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2019 06:51:26 +0100 Original-Received: from localhost ([::1]:44152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iObSX-000797-2F for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2019 01:51:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60082) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iObSQ-0006x9-K9 for emacs-devel@gnu.org; Sun, 27 Oct 2019 01:51:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iObSP-000337-On; Sun, 27 Oct 2019 01:51:17 -0400 Original-Received: from [176.228.60.248] (port=1042 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iObSP-0005zB-6n; Sun, 27 Oct 2019 01:51:17 -0400 In-reply-to: <453335474.949467.1572131620451@mail.yahoo.com> (message from Ergus on Sat, 26 Oct 2019 23:13:40 +0000 (UTC)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241502 Archived-At: > Date: Sat, 26 Oct 2019 23:13:40 +0000 (UTC) > From: Ergus > Cc: ingo.lohmar@posteo.net, emacs-devel@gnu.org > > Ohh right, that's the other commit. When fixing this issue I found another error I didn't see in tui. After EOL we > need to fill with the merged filtered face. To do that we need to add a stretch glyph; but we were just adding a > normal glyph with a ' ' so the face was not really extended, just the background color because the X display > engine always do that. But, for example, underline was not extended. This commit fixes just that. > stretch_ascent was moved out of the if(column_indicator) because the new stretch_glyphs needs it any way > and the two comments were 1) for old moved code not there anymore and 2) to describe the situation of the > glyphs color extension (mention in previous paragraph) that we don't need to work around anymore because > the glyph fills the entire screen now.. I'm still a bit confused: was the problem you found happening in GUI frames or in text-mode frames? You say "tui", but then talk about something X does...