From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: BIKESHED: completion faces Date: Fri, 08 Nov 2019 16:07:42 +0200 Message-ID: <831ruicvgx.fsf@gnu.org> References: <87zhhaxalt.fsf@gmail.com> <83bltpgffr.fsf@gnu.org> <83tv7gg9oz.fsf@gnu.org> <83r22kg8pa.fsf@gnu.org> <20191106205133.njij3ve7qqy7yh3q@Ergus> <83ftizg4nr.fsf@gnu.org> <8336ezg2vm.fsf@gnu.org> <83wocbelu1.fsf@gnu.org> <83imnvegcp.fsf@gnu.org> <83ftizeelw.fsf@gnu.org> <83bltne6oq.fsf@gnu.org> <87lfsrqs63.fsf@gmail.com> <838soqeuzr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="18724"; mail-complaints-to="usenet@blaine.gmane.org" Cc: spacibba@aol.com, dgutov@yandex.ru, joaotavora@gmail.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 08 15:11:05 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iT4yd-0004hl-Bk for ged-emacs-devel@m.gmane.org; Fri, 08 Nov 2019 15:11:03 +0100 Original-Received: from localhost ([::1]:54954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT4ya-00076c-23 for ged-emacs-devel@m.gmane.org; Fri, 08 Nov 2019 09:11:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34480) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT4vk-0003mK-Lq for emacs-devel@gnu.org; Fri, 08 Nov 2019 09:08:05 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iT4vk-0003c7-5r; Fri, 08 Nov 2019 09:08:04 -0500 Original-Received: from [176.228.60.248] (port=4708 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iT4vi-0008Pw-O6; Fri, 08 Nov 2019 09:08:03 -0500 In-reply-to: (message from Stefan Monnier on Fri, 08 Nov 2019 07:58:43 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241983 Archived-At: > From: Stefan Monnier > Cc: João Távora , > spacibba@aol.com, > emacs-devel@gnu.org, dgutov@yandex.ru > Date: Fri, 08 Nov 2019 07:58:43 -0500 > > >> fabrobazor > >> ^ ^ ^ > >> `---`---`----- I want these bold by default in the future > [...] > > I understand that what I called completions-match-emphasis will > > highlight f, o, and o -- the characters that were in the string typed > > by the user. These are currently not highlighted at all. > > They're currently "highlighted" with the `completions-common-part` face, > which by default so far has no visible attribute, so it "looks" > not-highlighted. So we agree, yes? They are currently NOT highlighted, although they do have a distinct face. Anyway, what you write seems to contradict what João was saying regarding the use of these faces. Or maybe I'm still confused. > I'd like to change that so the face has a "blue3" How will the user know the difference between these two highlightings? Are you counting on them to remember what they typed? What about completion in contexts where the user didn't type anything, like when they type "?"