all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: ynyaaa@gmail.com, martin rudalics <rudalics@gmx.at>
Cc: 38645@debbugs.gnu.org
Subject: bug#38645: 26.3; minibuffer input is called with multi-line window when multi-line message is shown
Date: Thu, 26 Dec 2019 22:49:45 +0200	[thread overview]
Message-ID: <831rsqrevq.fsf@gnu.org> (raw)
In-Reply-To: <86fthfu3qe.fsf@gmail.com> (ynyaaa@gmail.com)

> From: ynyaaa@gmail.com
> Cc: 38645@debbugs.gnu.org
> Date: Fri, 20 Dec 2019 11:16:31 +0900
> 
> With (setq resize-mini-windows t), the key sequence below shows message
> in one-line window. Then input motion commands and the minibuffer is
> redisplayed in one-line window. Eval: prompt is hidden.
> 
> M-:
> C-q C-j
> ?a
> C-x C-e

Martin, what do you think about the following fix?  Is it correct, and
if so, safe enough for the release branch?

diff --git a/src/xdisp.c b/src/xdisp.c
index 3080f8920a..438267350f 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -11562,7 +11562,15 @@ resize_mini_window (struct window *w, bool exact_p)
 
       SET_MARKER_FROM_TEXT_POS (w->start, start);
 
-      if (EQ (Vresize_mini_windows, Qgrow_only))
+      if (EQ (Vresize_mini_windows, Qgrow_only)
+	  /* Don't automatically shrink the mini-window, even if
+	     resize-mini-windows is t, if we are displaying an
+	     echo-area message while the minibuffer is active.  */
+	  || (minibuf_level > 0
+	      && WINDOW_LIVE_P (minibuf_window)
+	      && XWINDOW (minibuf_window) == w
+	      && !NILP (echo_area_buffer[0])
+	      && EQ (echo_area_window, minibuf_window)))
 	{
 	  /* Let it grow only, until we display an empty message, in which
 	     case the window shrinks again.  */





  reply	other threads:[~2019-12-26 20:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  6:49 bug#38645: 26.3; minibuffer input is called with multi-line window when multi-line message is shown ynyaaa
2019-12-17  7:41 ` Eli Zaretskii
2019-12-17 11:55 ` ynyaaa
2019-12-17 12:07   ` Eli Zaretskii
2019-12-18 10:52     ` ynyaaa
2019-12-18 16:31       ` Eli Zaretskii
2019-12-20  2:16         ` ynyaaa
2019-12-26 20:49           ` Eli Zaretskii [this message]
2019-12-27  9:12             ` martin rudalics
2019-12-27  9:21               ` Eli Zaretskii
2019-12-27  9:46                 ` martin rudalics
2019-12-27 10:29                   ` Eli Zaretskii
2019-12-29 14:15               ` Eli Zaretskii
2019-12-29 18:33                 ` martin rudalics
2019-12-29 18:50                   ` Eli Zaretskii
2019-12-29 19:30                     ` martin rudalics
2019-12-30 16:07                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831rsqrevq.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38645@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    --cc=ynyaaa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.