all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Cecilio Pardo <cpardo@imayhem.com>
Cc: 38794@debbugs.gnu.org
Subject: bug#38794: 26.1; Warnings in w32 build
Date: Sun, 29 Dec 2019 19:20:32 +0200	[thread overview]
Message-ID: <831rsnnj4v.fsf@gnu.org> (raw)
In-Reply-To: <86zhfb86ee.fsf@inmotica-integral.es> (message from Cecilio Pardo on Sun, 29 Dec 2019 17:04:41 +0100)

tags 38794 wontfix
close 38794
thanks

> From: Cecilio Pardo <cpardo@imayhem.com>
> Date: Sun, 29 Dec 2019 17:04:41 +0100
> 
> I am getting some warnings building with mingw64, using gcc 9.2.0. It
> complies about possible buffer overruns with sprintf. Maybe upgrade to snprintf?
> 
> This is the warnings message:
> 
> addpm.c: In function 'main':
> addpm.c:291:37: warning: '\bin\' directive writing 5 bytes into a region of size between 2 and 261 [-Wformat-overflow=]
>   291 |        sprintf (full_emacs_path, "%s\\bin\\%s", emacs_path, prog_name);
>       |                                     ^~~~~~~
> addpm.c:291:8: note: 'sprintf' output between 18 and 277 bytes into a destination of size 261
>   291 |        sprintf (full_emacs_path, "%s\\bin\\%s", emacs_path, prog_name);
>       |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

They are bogus, obviously, and we would like to deprecate and remove
addpm at some future point.  So I see no reason to make it compile
cleanly with GCC's too radical warning options.

So I'm closing this bug report.

Thank you anyway for your interest in Emacs and for providing a patch.





      reply	other threads:[~2019-12-29 17:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-29 16:04 bug#38794: 26.1; Warnings in w32 build Cecilio Pardo
2019-12-29 17:20 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831rsnnj4v.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38794@debbugs.gnu.org \
    --cc=cpardo@imayhem.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.