From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38583: [PATCH] 27.0.50; Add unattended spell-checking to checkdoc Date: Fri, 17 Jan 2020 11:49:56 +0200 Message-ID: <831rry2z0b.fsf@gnu.org> References: <87immlw7zo.fsf@cassou.me> <83blsc8ujl.fsf@gnu.org> <871rt8gfy0.fsf@cassou.me> <83mubw6lpb.fsf@gnu.org> <87o8vu7zqp.fsf@cassou.me> <83d0c9q2t3.fsf@gnu.org> <87blrt7rso.fsf@cassou.me> <874kx28b7m.fsf@cassou.me> <83sgkm6uxj.fsf@gnu.org> <87o8v8q6f7.fsf@cassou.me> <83k15r2qdw.fsf@gnu.org> <87muanqfe2.fsf@cassou.me> <83blr2344q.fsf@gnu.org> <87zhem8nb2.fsf@cassou.me> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="123874"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alex.branham@gmail.com, eggert@cs.ucla.edu, k.stevens@ieee.org, 38583@debbugs.gnu.org, zappo@gnu.org, larsi@gnus.org To: Damien Cassou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 17 10:51:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1isOHa-000Vvw-74 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jan 2020 10:51:14 +0100 Original-Received: from localhost ([::1]:54670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isOHY-0002QZ-Sz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Jan 2020 04:51:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51184) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1isOHP-0002NZ-Ti for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 04:51:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1isOHO-0007tN-SF for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 04:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1isOHO-0007t4-PC for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 04:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1isOHO-0003Dm-GS for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2020 04:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2020 09:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38583 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38583-submit@debbugs.gnu.org id=B38583.157925461612332 (code B ref 38583); Fri, 17 Jan 2020 09:51:02 +0000 Original-Received: (at 38583) by debbugs.gnu.org; 17 Jan 2020 09:50:16 +0000 Original-Received: from localhost ([127.0.0.1]:38857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isOGa-0003Ck-Dv for submit@debbugs.gnu.org; Fri, 17 Jan 2020 04:50:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isOGV-0003CJ-6I for 38583@debbugs.gnu.org; Fri, 17 Jan 2020 04:50:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1isOGO-00077J-M9; Fri, 17 Jan 2020 04:50:00 -0500 Original-Received: from [176.228.60.248] (port=3983 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1isOGN-0004nO-Qm; Fri, 17 Jan 2020 04:50:00 -0500 In-reply-to: <87zhem8nb2.fsf@cassou.me> (message from Damien Cassou on Fri, 17 Jan 2020 10:06:09 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174752 Archived-At: > From: Damien Cassou > Cc: 38583-done@debbugs.gnu.org, k.stevens@ieee.org, zappo@gnu.org, > alex.branham@gmail.com, larsi@gnus.org, eggert@cs.ucla.edu > Date: Fri, 17 Jan 2020 10:06:09 +0100 > > Eli Zaretskii writes: > > In general, yes. But you can try convincing me that it is so > > important to have in Emacs 27 that we should make an exception. I > > considered this, and concluded that it's a minor convenience feature. > > But maybe I'm missing something? > > Integrating into Emacs 27 late in the process is risky because my code > could have introduced subtle bugs inside checkdoc and I would not like > to be responsible for a delay in the release. That being said and > checkdoc being automatically activated by flycheck (which I believe many > people use), I think we will find bugs in my code quite fast if there > are any. Moreover, I think that improving the overall quality of Emacs > code is important and every little step in this direction would be > helpful. > > I'm not sure this is convincing enough but I would have tried :-D. OK, I've cherry-picked this to the release branch, mainly because it narrowly missed the branching due to delays in our review of the patch. > FYI, this work on checkdoc is part of a larger piece of work I've > started some years ago on improving the quality of Emacs packages. Here > are some of my activities in this area: Thank you for your work on this.