From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings Date: Thu, 13 Feb 2020 21:36:29 +0200 Message-ID: <831rqyqnya.fsf@gnu.org> References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="9773"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 37215@debbugs.gnu.org, larsi@gnus.org To: Wolfgang Scherer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 13 20:37:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2KIT-0002Sp-60 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Feb 2020 20:37:13 +0100 Original-Received: from localhost ([::1]:58416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2KIS-0002Nb-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Feb 2020 14:37:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33011) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2KIJ-0002ID-GU for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2020 14:37:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2KII-0006Pv-HV for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2020 14:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54526) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2KII-0006Pe-Dl for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2020 14:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j2KII-0007lR-B5 for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2020 14:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Feb 2020 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37215-submit@debbugs.gnu.org id=B37215.158162259529809 (code B ref 37215); Thu, 13 Feb 2020 19:37:02 +0000 Original-Received: (at 37215) by debbugs.gnu.org; 13 Feb 2020 19:36:35 +0000 Original-Received: from localhost ([127.0.0.1]:60499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2KHq-0007ki-Vm for submit@debbugs.gnu.org; Thu, 13 Feb 2020 14:36:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2KHp-0007kV-70 for 37215@debbugs.gnu.org; Thu, 13 Feb 2020 14:36:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2KHk-0004xl-0b; Thu, 13 Feb 2020 14:36:28 -0500 Original-Received: from [176.228.60.248] (port=1327 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2KHj-0003dw-86; Thu, 13 Feb 2020 14:36:27 -0500 In-reply-to: <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> (message from Wolfgang Scherer on Thu, 30 Jan 2020 20:44:00 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176015 Archived-At: > From: Wolfgang Scherer > Date: Thu, 30 Jan 2020 20:44:00 +0100 > Cc: 37215@debbugs.gnu.org > > >> -(defun vc-cvs-ignore (file &optional _directory _remove) > >> - "Ignore FILE under CVS." > >> - (vc-cvs-append-to-ignore (file-name-directory file) file)) > >> +(defun vc-cvs-ignore (file &optional directory _remove) > >> + "Ignore FILE under CVS. > >> +FILE is either absolute or relative to DIRECTORY." > >> + (setq file (directory-file-name (expand-file-name file directory))) > >> + (vc-cvs-append-to-ignore (file-name-directory file) (file-name-nondirectory file))) > > This is basically > > > > (file-name-nondirectory (directory-file-name (expand-file-name "foo" directory))) > > > > isn't it? > It is for `file` equal to "foo" (a simple basename). > > In what circumstances does that evaluate to something other > > than "foo"? > If "foo" is something other than a simple basename (see below). > > That is, what DIRECTORY is doesn't seem to matter, if I'm > > reading this right? > > Your assumption, that `file` is always a simple basename is wrong. Yes, but when does it make sense to have FILE not absolute and not just a basename (i.e. with leading directories)? Do we have such use cases? Because if that happens, the file's name will be added to .cvsignore not in DIRECTORY but in one of its subdirectories. Would that be surprising? And if so, perhaps we should warn about that or even error out?